Page MenuHomeFreeBSD
Feed Advanced Search

Dec 13 2021

avg requested review of D33413: MFC r368649 / 3fd989da by kib: amd64 pmap: fix PCID mode invalidations.
Dec 13 2021, 12:40 PM
avg added a reverting change for D33412: mmc_sim: fix setting of the mutex name: rG8b37048bc548: Revert "mmc_sim: fix setting of the mutex name".
Dec 13 2021, 11:53 AM
avg added a reverting change for rGdf472af034e7: mmc_sim: fix setting of the mutex name: rG8b37048bc548: Revert "mmc_sim: fix setting of the mutex name".
Dec 13 2021, 11:53 AM
avg committed rG8b37048bc548: Revert "mmc_sim: fix setting of the mutex name" (authored by avg).
Revert "mmc_sim: fix setting of the mutex name"
Dec 13 2021, 11:53 AM
avg committed rGb277ef3304fa: ds3231: fix accidental breakage of !FDT in 1256067c (authored by avg).
ds3231: fix accidental breakage of !FDT in 1256067c
Dec 13 2021, 11:52 AM
avg closed D33412: mmc_sim: fix setting of the mutex name.
Dec 13 2021, 11:52 AM
avg committed rGdf472af034e7: mmc_sim: fix setting of the mutex name (authored by avg).
mmc_sim: fix setting of the mutex name
Dec 13 2021, 11:52 AM
avg added a reviewer for D33412: mmc_sim: fix setting of the mutex name: imp.
Dec 13 2021, 11:46 AM
avg requested review of D33412: mmc_sim: fix setting of the mutex name.
Dec 13 2021, 11:45 AM
avg committed rG1256067c5c57: ds3231: allow configuration via hints on FDT systems (authored by avg).
ds3231: allow configuration via hints on FDT systems
Dec 13 2021, 11:41 AM
avg committed rGb416345d5b13: pcf8591: remove write-only variables (authored by avg).
pcf8591: remove write-only variables
Dec 13 2021, 11:40 AM
avg committed rGcca0d3bbd8c9: amdsbwd: always enable watchdog register decoding (authored by avg).
amdsbwd: always enable watchdog register decoding
Dec 13 2021, 11:37 AM
avg committed rGde63ba95e382: rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1 (authored by Andreas Wetzel <mickey242@gmx.net>).
rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1
Dec 13 2021, 6:37 AM
avg committed rG99e934e6f152: rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1 (authored by Andreas Wetzel <mickey242@gmx.net>).
rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1
Dec 13 2021, 6:36 AM

Dec 10 2021

avg committed rGf43d2e1199b9: iflib_stop: drain rx tasks to prevent any data races (authored by avg).
iflib_stop: drain rx tasks to prevent any data races
Dec 10 2021, 12:34 PM
avg committed rG5f24d2a82c1f: iflib_stop: drain rx tasks to prevent any data races (authored by avg).
iflib_stop: drain rx tasks to prevent any data races
Dec 10 2021, 12:33 PM
avg committed rG3507728e59ab: twsi: unify error handling, explicitly handle more conditions (authored by avg).
twsi: unify error handling, explicitly handle more conditions
Dec 10 2021, 12:32 PM
avg committed rG035813ba1554: twsi: improve a handful of debug messages (authored by avg).
twsi: improve a handful of debug messages
Dec 10 2021, 12:32 PM
avg committed rG1fc756504f7c: twsi: do not attempt transfer if bus is not idle (authored by avg).
twsi: do not attempt transfer if bus is not idle
Dec 10 2021, 12:32 PM
avg committed rGdebb15c63d62: twsi: remove redundant enabling of the controller (authored by avg).
twsi: remove redundant enabling of the controller
Dec 10 2021, 12:32 PM
avg committed rG4030ad30b2fe: twsi: protect interaction between twsi_transfer and twsi_intr (authored by avg).
twsi: protect interaction between twsi_transfer and twsi_intr
Dec 10 2021, 12:32 PM
avg committed rG0f048f199e69: twsi: unify error handling, explicitly handle more conditions (authored by avg).
twsi: unify error handling, explicitly handle more conditions
Dec 10 2021, 12:31 PM
avg committed rG22989451b4c5: twsi: improve a handful of debug messages (authored by avg).
twsi: improve a handful of debug messages
Dec 10 2021, 12:31 PM
avg committed rG5efa75707b21: twsi: do not attempt transfer if bus is not idle (authored by avg).
twsi: do not attempt transfer if bus is not idle
Dec 10 2021, 12:31 PM
avg committed rGbb8fac1ee1fa: twsi: remove redundant enabling of the controller (authored by avg).
twsi: remove redundant enabling of the controller
Dec 10 2021, 12:31 PM
avg committed rG109000c32ddc: twsi: protect interaction between twsi_transfer and twsi_intr (authored by avg).
twsi: protect interaction between twsi_transfer and twsi_intr
Dec 10 2021, 12:31 PM

Dec 6 2021

avg added a comment to D33302: zfs boot: prefer a pool with bootfs set for a boot pool.

Well, I do not want to solve all problems with this small patch.
I just want to improve the situation for most typical installs.
Single pool - no problems and nothing changes.
Single boot pool, one or more data pool - the situation becomes better, just set bootfs on the boot pool.
Multiple boot pools - the situation remains just as it was before.

Dec 6 2021, 4:52 PM
avg added a comment to D33302: zfs boot: prefer a pool with bootfs set for a boot pool.
In D33302#752740, @imp wrote:

What does 'first' mean? It's effectively a random list, in random order since there's no boot priority indicated. Why would you prefer something random here? What if there are two or three? This can lead to weird behavior.

Dec 6 2021, 4:35 PM
avg added reviewers for D33302: zfs boot: prefer a pool with bootfs set for a boot pool: imp, oshogbo, tsoome.
Dec 6 2021, 12:45 PM
avg requested review of D33302: zfs boot: prefer a pool with bootfs set for a boot pool.
Dec 6 2021, 12:42 PM
avg committed rG9c612a5d0af1: vmxnet3: skip zero-length descriptor in the middle of a packet (authored by avg).
vmxnet3: skip zero-length descriptor in the middle of a packet
Dec 6 2021, 8:01 AM
avg closed D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.
Dec 6 2021, 8:01 AM
avg committed rGcd6f0b47692c: rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1 (authored by Andreas Wetzel <mickey242@gmx.net>).
rtwn/usb: add product ID for Asus USB N10 Nano Rev. B1
Dec 6 2021, 7:44 AM

Dec 3 2021

avg committed rGbce1efdcf040: twsi: compile in support for debug messages, disabled by default (authored by avg).
twsi: compile in support for debug messages, disabled by default
Dec 3 2021, 11:31 AM
avg committed rGb26743df026b: twsi: remove write-only softc field (authored by avg).
twsi: remove write-only softc field
Dec 3 2021, 11:30 AM
avg committed rG906191040efb: twsi: add more of status definitions (authored by avg).
twsi: add more of status definitions
Dec 3 2021, 11:30 AM
avg committed rGdf6cb9c5cbca: twsi: sort headers, remove unneeded (authored by avg).
twsi: sort headers, remove unneeded
Dec 3 2021, 11:30 AM
avg committed rGd2e1ee61cf95: rk_spi: declare support for rk3328 (authored by avg).
rk_spi: declare support for rk3328
Dec 3 2021, 11:29 AM
avg committed rGa138038f6934: twsi: compile in support for debug messages, disabled by default (authored by avg).
twsi: compile in support for debug messages, disabled by default
Dec 3 2021, 7:27 AM
avg committed rGbab53d35329c: twsi: sort headers, remove unneeded (authored by avg).
twsi: sort headers, remove unneeded
Dec 3 2021, 7:27 AM
avg committed rGc141cad41d94: twsi: remove write-only softc field (authored by avg).
twsi: remove write-only softc field
Dec 3 2021, 7:27 AM
avg committed rG3b7478a7c4df: twsi: add more of status definitions (authored by avg).
twsi: add more of status definitions
Dec 3 2021, 7:27 AM

Dec 2 2021

avg committed rG34aa8c27cd06: rk_spi: declare support for rk3328 (authored by avg).
rk_spi: declare support for rk3328
Dec 2 2021, 6:38 AM

Dec 1 2021

avg updated the diff for D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.

better name for the new counter and its sysctl

Dec 1 2021, 8:07 AM
avg added a comment to D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.

@pkelsey , thank you very much for the very detailed review and feedback.
It will certainly be useful if another problem (or a variation of the current one) strikes us.

Dec 1 2021, 8:02 AM

Nov 30 2021

avg added inline comments to D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.
Nov 30 2021, 2:18 PM
avg updated the diff for D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.

add __predict_true for the normal case

Nov 30 2021, 2:17 PM
avg added inline comments to D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.
Nov 30 2021, 1:59 PM
avg added reviewers for D33189: vmxnet3: skip zero-length descriptor in the middle of a packet: pkelsey, markj, iflib.
Nov 30 2021, 1:58 PM
avg requested review of D33189: vmxnet3: skip zero-length descriptor in the middle of a packet.
Nov 30 2021, 1:57 PM
avg committed rG3d9d64aa1846: kern_tc: unify timecounter to bintime delta conversion (authored by avg).
kern_tc: unify timecounter to bintime delta conversion
Nov 30 2021, 1:35 PM
avg closed D32324: bsd.port.mk: Do not pass FLAVOR in dependency make environment.
Nov 30 2021, 12:39 PM
avg committed R11:a50c18ba3174: bsd.port.mk: Do not pass FLAVOR in dependency make environment (authored by ross_ross-williams.net).
bsd.port.mk: Do not pass FLAVOR in dependency make environment
Nov 30 2021, 12:39 PM

Nov 29 2021

avg accepted D33139: libdwarf: Support consumption of compressed ELF sections.

Other than the lib32 error, everything seems to have worked fine.

Nov 29 2021, 6:39 AM
avg added inline comments to D33139: libdwarf: Support consumption of compressed ELF sections.
Nov 29 2021, 6:35 AM

Nov 27 2021

avg committed rGad5904ec5913: icee: allow configuration via hints on FDT-based systems (authored by avg).
icee: allow configuration via hints on FDT-based systems
Nov 27 2021, 8:53 AM
avg committed rG45a19f61218b: ds1307: allow configuration via hints on FDT-based systems (authored by avg).
ds1307: allow configuration via hints on FDT-based systems
Nov 27 2021, 8:53 AM
avg committed rG06f49eaf13bd: sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes (authored by avg).
sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes
Nov 27 2021, 8:52 AM
avg committed rGf537b3056421: icee: allow configuration via hints on FDT-based systems (authored by avg).
icee: allow configuration via hints on FDT-based systems
Nov 27 2021, 8:50 AM
avg committed rG83f68b84c234: ds1307: allow configuration via hints on FDT-based systems (authored by avg).
ds1307: allow configuration via hints on FDT-based systems
Nov 27 2021, 8:50 AM
avg committed rGa9f6a79b2d6a: sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes (authored by avg).
sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes
Nov 27 2021, 8:50 AM

Nov 26 2021

avg committed rGff1e8581806f: twsi: support more message combinations in transfers (authored by avg).
twsi: support more message combinations in transfers
Nov 26 2021, 2:25 PM
avg committed rGaeacf172fd29: twsi: remove redundant write of control register (authored by avg).
twsi: remove redundant write of control register
Nov 26 2021, 2:25 PM
avg committed rG00c07d9559c6: twsi: make data receiving code safer (authored by avg).
twsi: make data receiving code safer
Nov 26 2021, 2:24 PM
avg committed rG04622a7f2115: twsi: move handling of TWSI_CONTROL_ACK into the state machine (authored by avg).
twsi: move handling of TWSI_CONTROL_ACK into the state machine
Nov 26 2021, 2:24 PM
avg committed rGa4fe8922085d: twsi: unify error handling, explicitly handle more conditions (authored by avg).
twsi: unify error handling, explicitly handle more conditions
Nov 26 2021, 2:24 PM
avg committed rG578707ed4efd: twsi: improve a handful of debug messages (authored by avg).
twsi: improve a handful of debug messages
Nov 26 2021, 2:24 PM
avg committed rGbc02583c4dd6: twsi: remove redundant enabling of the controller (authored by avg).
twsi: remove redundant enabling of the controller
Nov 26 2021, 2:24 PM
avg committed rGcb167e1ae954: twsi: do not attempt transfer if bus is not idle (authored by avg).
twsi: do not attempt transfer if bus is not idle
Nov 26 2021, 2:24 PM
avg committed rG69cfa60ddd4d: twsi: protect interaction between twsi_transfer and twsi_intr (authored by avg).
twsi: protect interaction between twsi_transfer and twsi_intr
Nov 26 2021, 2:24 PM
avg committed rG26559dd1770b: twsi: sort headers, remove unneeded (authored by avg).
twsi: sort headers, remove unneeded
Nov 26 2021, 2:24 PM
avg committed rGa2793d618225: twsi: compile in support for debug messages, disabled by default (authored by avg).
twsi: compile in support for debug messages, disabled by default
Nov 26 2021, 2:24 PM
avg committed rGf00bc54f62c4: twsi: remove write-only softc field (authored by avg).
twsi: remove write-only softc field
Nov 26 2021, 2:24 PM
avg committed rGde86f339cdda: twsi: add more of status definitions (authored by avg).
twsi: add more of status definitions
Nov 26 2021, 2:24 PM
avg accepted D33126: Fix build with -DNO_ROOT.
Nov 26 2021, 11:46 AM

Nov 25 2021

avg committed rG8c12ee5021e2: rk_spi: declare support for rk3328 (authored by avg).
rk_spi: declare support for rk3328
Nov 25 2021, 9:29 PM
avg added a comment to D30990: src.sys.obj.mk: Export OBJTOP like OBJROOT.

I see that this review has kind of stalled.

Nov 25 2021, 9:08 AM

Nov 24 2021

avg committed rGf1d2f22b34ab: pca954x: driver for PCA954x / TCA954x I2C switches (authored by avg).
pca954x: driver for PCA954x / TCA954x I2C switches
Nov 24 2021, 2:22 PM

Nov 21 2021

avg committed rG1f39ef9fa810: rk805: add system poweroff support (authored by avg).
rk805: add system poweroff support
Nov 21 2021, 10:06 AM
avg committed rG9d7c92dbb9bf: add rk3328 overlay for enabling analog sound (authored by avg).
add rk3328 overlay for enabling analog sound
Nov 21 2021, 10:06 AM
avg committed rG128a6d31f2dc: camcontrol: dump received data for MMC command even if it is unknown (authored by avg).
camcontrol: dump received data for MMC command even if it is unknown
Nov 21 2021, 10:06 AM
avg committed rGee82e15cd9fc: pcf8574: driver for 8-pin quasi-bidirectional GPIO over I2C (authored by avg).
pcf8574: driver for 8-pin quasi-bidirectional GPIO over I2C
Nov 21 2021, 10:06 AM
avg committed rGad235cff36a1: camcontrol: dump received data for MMC command even if it is unknown (authored by avg).
camcontrol: dump received data for MMC command even if it is unknown
Nov 21 2021, 10:05 AM

Nov 19 2021

avg committed rG1bfdb812c786: iflib_stop: drain rx tasks to prevent any data races (authored by avg).
iflib_stop: drain rx tasks to prevent any data races
Nov 19 2021, 8:02 AM
avg closed D32926: iflib_stop: drain rx tasks to prevent any data races.
Nov 19 2021, 8:02 AM

Nov 13 2021

avg committed rGc0525ab1d1ce: pca954x: driver for PCA954x / TCA954x I2C switches (authored by avg).
pca954x: driver for PCA954x / TCA954x I2C switches
Nov 13 2021, 9:29 AM
avg committed rG01e3492337cb: icee: allow configuration via hints on FDT-based systems (authored by avg).
icee: allow configuration via hints on FDT-based systems
Nov 13 2021, 9:25 AM
avg committed rG27645265c4e4: ds1307: allow configuration via hints on FDT-based systems (authored by avg).
ds1307: allow configuration via hints on FDT-based systems
Nov 13 2021, 9:24 AM
avg committed rG53b356f17ab8: audio_soc: remove useless call to pcm_getbuffersize (authored by avg).
audio_soc: remove useless call to pcm_getbuffersize
Nov 13 2021, 9:22 AM
avg committed rGe17b58ecbcb6: sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes (authored by avg).
sddadone: 'error' gets assigned only errno codes, never MMC_ERR codes
Nov 13 2021, 9:21 AM
avg committed rG81eae1144593: Revert "files.arm64: fix sort order for aw_i2s.c" (authored by avg).
Revert "files.arm64: fix sort order for aw_i2s.c"
Nov 13 2021, 9:17 AM
avg added a reverting change for rG25fb4fb2518f: files.arm64: fix sort order for aw_i2s.c: rG81eae1144593: Revert "files.arm64: fix sort order for aw_i2s.c".
Nov 13 2021, 9:17 AM
avg committed rG25fb4fb2518f: files.arm64: fix sort order for aw_i2s.c (authored by avg).
files.arm64: fix sort order for aw_i2s.c
Nov 13 2021, 9:14 AM
avg committed rG7785ea337373: gpioled: allow the driver to be disabled via fdt (authored by avg).
gpioled: allow the driver to be disabled via fdt
Nov 13 2021, 9:13 AM
avg committed rG8f57430de139: driver for MAX44009 I2C illuminance sensor (authored by avg).
driver for MAX44009 I2C illuminance sensor
Nov 13 2021, 9:13 AM
avg committed rGd6f71e09a789: pcf8591: driver for adc/dac with i2c interface (authored by avg).
pcf8591: driver for adc/dac with i2c interface
Nov 13 2021, 9:11 AM
avg committed rG00c06804a87c: add rk3328 overlay for enabling analog sound (authored by avg).
add rk3328 overlay for enabling analog sound
Nov 13 2021, 9:10 AM
avg committed rG737ed8b99f7d: htu21: allow configuration via hints on FDT-based systems (authored by avg).
htu21: allow configuration via hints on FDT-based systems
Nov 13 2021, 9:06 AM
avg committed rGc9882d7600f9: htu21: don't needlessly bother hardware when measurements are not needed (authored by avg).
htu21: don't needlessly bother hardware when measurements are not needed
Nov 13 2021, 9:05 AM

Nov 12 2021

avg accepted D32931: zfs: Fix a deadlock between page busy and the teardown lock.

Thank you very much! This is a very neat fix for what appeared as a quite substantial problem (and maybe is, in terms of interactions between layers / subsystems).

Nov 12 2021, 10:04 AM