I have not reviewed the entire driver because I ran into enough issues I want addressed first to warrant a highlevel comment first.

add Ryzen specific SMU registers.

Add support Bristol Ridge, possible Ryzen - need check
Remove TSI reading methods

I m waiting for documentation from AMD to Ryzen CPU, looks like 17h have new interfaces.

On

CPU: AMD Ryzen 7 1700X Eight-Core Processor          (3393.69-MHz K8-class CPU)

I get the following results:

sysctl dev.amdtemp

dev.amdtemp.0.rtc.sensor_offset: 0
dev.amdtemp.0.rtc.PerStepTimeUp: 0
dev.amdtemp.0.rtc.PerStepTimeDn: 0
dev.amdtemp.0.rtc.TmpMaxDiffUp: 0
dev.amdtemp.0.rtc.TmpSlewDnEn: 0
dev.amdtemp.0.rtc.CurTmpTjSel: -49.0C
dev.amdtemp.0.rtc.CurTmp: 0.1C
dev.amdtemp.0.%parent: hostb10
dev.amdtemp.0.%pnpinfo:
dev.amdtemp.0.%location:
dev.amdtemp.0.%driver: amdtemp
dev.amdtemp.0.%desc: AMD CPU On-Die Thermal Sensors
dev.amdtemp.%parent:

In D9759#204651, @cy wrote:

Will there be man page updates?

Since revision 310051 sysctl_add_oid have +1 param, add macro to handle it.

Will there be man page updates?

We can commit this once we get more testing done.

In D9759#204260, @rozhuk.im-gmail.com wrote:

I have some AMD: E350, 5350, APU 6800, Phenom II X4 955 - test OK.

I have some AMD: E350, 5350, APU 6800, Phenom II X4 955 - test OK.

How can we test this on all hardware versions? I don't have AMD hardware. You could ask on the mailing list.

Style update.
CTASSERT() removed.

I will fix style a bi later.

This needs a lot of style fixes. Please read the style man page and check other drivers for examples.

Style corrections.

At first, Thanks for your great work __/|\__
Technically I'm not right person to talk deeply about this.
But for helping to reduce amount of works for next reviewer (and also for you ;D),
Some style(9) points:
use the form:

type
name()
{
}

instead of

type
name() {
}