ping?

In D8692#180275, @koobs wrote:

Please:

• Update revision SUMMARY to be in the format of a well-formed commit log message (surrounded by code blocks)

…

Reviewed by: blah blah blah
Approved by: blah blah blah
DiffRev: DXXXX

Obsolete due to 11.0 release.

Stuff disappeared from the commit 416253, so this didn't auto-close.

Seeing that there is still plenty of activity in stable/10, I think it's a good idea to MFC this after all.

Use WRKSRC_SUBDIR instead of modifying WRKSRC directly.

In D6617#139973, @mat wrote:

Please, run make makesum so that the distinfo file gets a TIMESTAMP.

Add timestamp to distinfo

In D5816#129668, @cs wrote:

Is there any reason you add the COPYING file in games/ioquake3/Makefile and games/openarena-oax/Makefile?

In D5744#129684, @cs wrote:

Don't use the current date as the date of the version. Use the date of the actual commit as the version number.

Use the latest commit date for the version suffix.

After some discussion on IRC, due to there being no current plans for a 10.4 release, the consent is that it would be more beneficial for 10.x users to have a solution in the ports tree.

Frankly I think plists create more problems than they solve, but my opinion is obviously a minority opinion. I'm glad I got some feedback out of this. Thanks for all the comments.

Add a can of bsd.options.mk fu.

Removed the obsolete plist target.

In D5748#122753, @antoine wrote:

I disagree, with autoplist you may end up with empty packages or silent breakages without realizing it.
The plist allows to do a basic sanity check (you have a failure when a precious file is no longer built/installed for instance).
I fixed many empty packages in the last years for instance, or packages where the library was magically bumped due to a dependency changing but PORTREVISION bump was missed because of autoplist.

Add diff created by arcanist.

Add long patch that shows all the context.

Fix build on 9.3.

Obsolete, works without the patch on all supported releases, now.

s/\+=/=/

Upstream now handles variable substitution for install paths, so only the variables instead of a whole sed command are required.

In D5510#117726, @mat wrote:

There is that, yes

Implements suggestions from mat.

In D5510#117709, @mat wrote:

Yes, and because other people did stupid things does not mean you have to.

Please don't.

In D5510#117460, @mat wrote:

Having + in the PORTNAME is a pain, and should be avoided. As the GitHub project is called powerdxx, maybe this port should be called that too. (even if it installs a powerd++ binary.)

There is, it might not be trivial to run, but I will investigate.

I don't see the need for PORTREVISION. There are no interface changes and thus no need to update on platforms where the build works without the patch.

Closed by commit rP379549 (authored by @kami).

In D1754#6, @cs wrote:

• Did you move the #endif on purpose down in src/file/mmc_device_linux.c ?

Closed by commit rD46070 (authored by @kami).