Page MenuHomeFreeBSD
Differential D8977

devel/rubygem-listen: add missing dependency
ClosedPublic
Actions

Authored by kami on Dec 29 2016, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 9:59 AM
Unknown Object (File)
Fri, Dec 20, 8:36 PM
Unknown Object (File)
Fri, Dec 20, 8:33 PM
Unknown Object (File)
Fri, Dec 20, 8:25 PM
Unknown Object (File)
Dec 14 2024, 4:32 PM
Unknown Object (File)
Dec 4 2024, 11:50 AM
Unknown Object (File)
Dec 1 2024, 10:38 PM
Unknown Object (File)
Nov 27 2024, 4:21 AM
View All 73 Files
Subscribers
mat
sunpoet
swills

Details

Reviewers
cs
koobs
mat
Commits
rP430727: devel/rubygem-listen: Add missing dependency
Summary
- Add missing dependency on devel/rubygem-ruby_dep


PR:           213500
Reported by:  freebsdbug@patpro.net
#Reviewed by:  ?
#Approved by:  ?
#Differential Revision: https://reviews.freebsd.org/D###
Test Plan

Tested in poudriere:

rel-archdevel/rubygem-listen
9.3-i386OK
9.3-amd64OK
10.3-i386OK
10.3-amd64OK
11.0-i386OK
11.0-amd64OK

The host system:
FreeBSD AprilRyan.norad 11.0-STABLE FreeBSD 11.0-STABLE #0 r310323

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kami updated this revision to Diff 23398.Dec 29 2016, 12:51 PM
kami retitled this revision from to devel/rubygem-listen: add missing dependency.
kami updated this object.
kami edited the test plan for this revision. (Show Details)
kami added reviewers: cs, koobs.
Herald added a subscriber: mat. · View Herald TranscriptDec 29 2016, 12:51 PM
kami added a child revision: D8978: www/rubygem-jekyll: fix dependency versions.Dec 29 2016, 12:56 PM
swills added a subscriber: swills.Dec 30 2016, 3:43 AM

LGTM, thanks for catching this

mat accepted this revision.Jan 6 2017, 3:38 PM
mat added a reviewer: mat.
This revision is now accepted and ready to land.Jan 6 2017, 3:38 PM
Closed by commit rP430727: devel/rubygem-listen: Add missing dependency (authored by kami). · Explain WhyJan 6 2017, 6:41 PM
This revision was automatically updated to reflect the committed changes.
sunpoet added a subscriber: sunpoet.Jan 6 2017, 7:43 PM

I wonder why you do not add maintainer as reviewer.

kami added a comment.Jan 6 2017, 8:38 PM
In D8977#187334, @sunpoet wrote:

I wonder why you do not add maintainer as reviewer.

Good point, I'm sorry.

To be honest I didn't even look at the maintainer. I just assumed it's ruby@freebsd.org.

Revision Contents
Changeset List

PathSize
head/
devel/
rubygem-listen/
3 lines

Diff 23664

View Options

head/devel/rubygem-listen/Makefile

Loading...