games/iourbanterror, games/urbanterror-data: Update Urban Terror 4.2.x to 4.3.1

[kami]

Summary

games/iourbanterror, games/urbanterror-data: Update from 4.2.x to 4.3.1

- Add license info to games/urbanterror-data
- Switch to URT proprietary engine codebase, because game data is no
  longer compatible to ioquake3

PR:           213703
Reported by:  [e-mail]
#Reviewed by:  koobs
Approved by:
#Differential Revision: https://reviews.freebsd.org/D8692

Test Plan

testport

rel\arch	urbanterror-data	iourbanterror-server	iourbanterror
10.3-amd64	OK	OK	OK
10.3-i386	OK	OK	OK
11.0-amd64	OK	OK	OK
11.0-i386	OK	OK	OK

[koobs]

Please:

• Update revision SUMMARY to be in the format of a well-formed commit log message (surrounded by code blocks)

category/port: Summary ...

* Itemized change 1, rationale / terse explanation
* Itemized change 2, rationale / terse explanation
* Itemized change N, rationale / terse explanation

Reviewed by: blah blah blah
Approved by: blah blah blah
DiffRev: DXXXX

• The build on 9.3 should be fixed
• Clarify whether the items in TEST PLAN have been run and what the results are/were, like:

testport: OK (93amd64, etc etc)

• Patches should contain header comments explaining with patch, with upstream URL references if they exist (ideally they do).
• Software changes/changelog should not be included in the port changes (top) section of the commit log, but should instead be a separate (bottom), or a URL to upstream release/version announcement (or git tagged changelog file) like:

Changes:

 * <url to upstream changelog>

[kami]

In D8692#180275, @koobs wrote:

Please:

• Update revision SUMMARY to be in the format of a well-formed commit log message (surrounded by code blocks)

…

Reviewed by: blah blah blah
Approved by: blah blah blah
DiffRev: DXXXX

There is a check that objects to my "Reviewed by:" and "Differential Revision:" entries. I prepended them by a #, maybe you can tell what's wrong.

• The build on 9.3 should be fixed

I won't fix llvm37.

• Clarify whether the items in TEST PLAN have been run and what the results are/were, like:

testport: OK (93amd64, etc etc)

I hope tabular is all right.

• Patches should contain header comments explaining with patch, with upstream URL references if they exist (ideally they do).

So, I can just dump text into a patch?

[kami]

ping?

[kami]

• Move patches to GitHub
• Pull requests:
  • https://github.com/Barbatos/ioq3-for-UrbanTerror-4/pull/59
  • https://github.com/Barbatos/ioq3-for-UrbanTerror-4/pull/60
• Report llvm37 failure: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215658

[mat]

Looks good. (mentors timeout)

games/iourbanterror/Makefile

9

I started saying that this line was wrong, it feels wrong at first sight, but is not because of the slave port thing, you should write something like:

MASTER_SITE=    # force empty because it is a slave port

50–51

can remove that.

[kami]

Address review concerns by mat.

Note poudriere testruns are still ongoing, will update the table
on completion.

[kami]

Poudriere testrun completed successfully, so I updated the test plan.

Also:

In D8692#185545, @kami wrote:

• Move patches to GitHub
• Pull requests:
  • https://github.com/Barbatos/ioq3-for-UrbanTerror-4/pull/59
  • https://github.com/Barbatos/ioq3-for-UrbanTerror-4/pull/60

Accepted upstream.

• Report llvm37 failure: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215658

Closed, because 9.x is EOL.

[kami]

A fix for CVE-2017-6903 is incoming.