Page MenuHomeFreeBSD

[new port] sysutils/powerd++
ClosedPublic

Authored by kami on Mar 1 2016, 5:06 PM.

Details

Summary

New port, no dependencies.

Test Plan
  • port test finished without complaint (with and without DOCS)
  • Also, xmj looked over it

poudriere tests: 10.2-release-amd64, 10.2-release-i386, 9.3-release-amd64, 9.3-release-i386 succeeded.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kami retitled this revision from to [new port] sysutils/powerd++.
kami updated this object.
kami edited the test plan for this revision. (Show Details)
kami added reviewers: cs, koobs.
kami set the repository for this revision to rP FreeBSD ports repository.
kami added a project: Ports Committers.

Having + in the PORTNAME is a pain, and should be avoided. As the GitHub project is called powerdxx, maybe this port should be called that too. (even if it installs a powerd++ binary.)

Not installing the man page is a very bad idea, this is FreeBSD, not Linux, we install the basic documentation with our software. And then, there is only one file which installation is controlled by the DOCS option, remove it, and always install the README.md file.

In D5510#117460, @mat wrote:

Having + in the PORTNAME is a pain, and should be avoided. As the GitHub project is called powerdxx, maybe this port should be called that too. (even if it installs a powerd++ binary.)

There is a lot of precendence:

> find /usr/ports/ -type d -name \*++\*
/usr/ports/science/voro++
/usr/ports/science/crf++
/usr/ports/games/xgalaga++
/usr/ports/sysutils/powerd++
/usr/ports/textproc/libxml++26
/usr/ports/textproc/libxml++26-reference
/usr/ports/benchmarks/bonnie++
/usr/ports/lang/tolua++
/usr/ports/lang/libstdc++_stldoc_4.2.2
/usr/ports/net/smm++
...

Naming the github project powerdxx was a workaround.

Yes, and because other people did stupid things does not mean you have to.

Please don't.

In D5510#117709, @mat wrote:

Yes, and because other people did stupid things does not mean you have to.

Please don't.

Everyone seems to think you are right, just like you, no one is giving me a reason. Very frustrating.

I'll go with the only one I could come up with myself - no characters with special meaning in a regexp.

Implements suggestions from mat.

There is that, yes. Also, subpackages, that are coming soon™, need a separator, that won't be anywhere in the package name, the + would be nice.

sysutils/powerdxx/Makefile
15 ↗(On Diff #13977)

It's not really clear what all this does.

I get it's some magic to pass some variables along, but I doubt you need everything, it would be easier to maintain if you did not abuse SUB_LIST but only passed the one you really need, PREFIX and DOCSDIR.

sysutils/powerdxx/pkg-plist
2–4 ↗(On Diff #13977)

remove the %%PORTDOCS%%, as there is no DOCS option, it does not do anything.

In D5510#117726, @mat wrote:

There is that, yes

Should that be a policy? I.e. should I draft an update to the package naming conventions?

. Also, subpackages, that are coming soon™, need a separator, that won't be anywhere in the package name, the + would be nice.

The would mean renaming 65 packages. Doable I guess, Also there a 348 ports with a . in the name.

Upstream now handles variable substitution for install paths, so only the variables instead of a whole sed command are required.

sysutils/powerdxx/Makefile
15 ↗(On Diff #14270)

No need to do +=

kami marked an inline comment as done.

s/\+=/=/

kami edited the test plan for this revision. (Show Details)
kami marked an inline comment as done.

Fix build on 9.3.

mat added a reviewer: mat.
This revision is now accepted and ready to land.Mar 26 2016, 6:36 AM
cs edited edge metadata.
This revision was automatically updated to reflect the committed changes.