Paths

Table of Contentst

Differential D33319

sdhci_fsl_fdt: Fix vccq reconfiguration
ClosedPublic
Actions

Authored by hum_semihalf.com on Dec 7 2021, 12:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 18, 12:00 AM

	Unknown Object (File)
	Wed, Apr 17, 11:58 PM

	Unknown Object (File)
	Wed, Apr 17, 10:22 PM

	Unknown Object (File)
	Wed, Apr 17, 10:18 PM

	Unknown Object (File)
	Wed, Apr 17, 6:47 PM

	Unknown Object (File)
	Wed, Apr 17, 6:37 PM

	Unknown Object (File)
	Wed, Apr 17, 6:29 PM

	Unknown Object (File)
	Wed, Apr 17, 6:28 PM

View All 63 Files

Subscribers

contact_artur-rojek.eu

Details

Reviewers

mw
wma
manu

Commits

rGec9333c3aac3: sdhci_fsl_fdt: Fix vccq reconfiguration

Summary

As vqmmc-supply is an optional Device Tree property, don't skip vccq
reconfiguration when the regulator is not specified. Instead, accept
voltage specified by the voltage-ranges property.

The actual voltage switch is done through a hw register in LS1028A.
Add errata flag for other boards, as they are not supported. Return
not supported error code when switching to 1.8V on affected platforms.

Fixes: b08bf4c3 ("sdhci_fsl_fdt: Skip vccq reconfiguration without regulator")

Co-authored-by: Artur Rojek <ar@semihalf.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hum_semihalf.com created this revision.Dec 7 2021, 12:19 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 7 2021, 12:19 PM

hum_semihalf.com requested review of this revision.Dec 7 2021, 12:19 PM

hum_semihalf.com added a parent revision: D33222: NXP: Implement errata workaround for SDHCI driver .

hum_semihalf.com added a child revision: D33320: sdhci_fsl_fdt: Add support for HS200/HS400 modes .Dec 7 2021, 12:22 PM

Update commit log.

manu requested changes to this revision.Dec 8 2021, 9:27 AM

manu added inline comments.

sys/dev/sdhci/sdhci_fsl_fdt.c
524	You don't need this variable.

This revision now requires changes to proceed.Dec 8 2021, 9:27 AM

Remove redundant variable.

manu accepted this revision.Dec 8 2021, 10:09 AM

This revision is now accepted and ready to land.Dec 8 2021, 10:09 AM

Closed by commit rGec9333c3aac3: sdhci_fsl_fdt: Fix vccq reconfiguration (authored by ar_semihalf.com, committed by wma). · Explain WhyDec 8 2021, 10:22 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rGec9333c3aac3: sdhci_fsl_fdt: Fix vccq reconfiguration.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci_fsl_fdt.c

44 lines

Diff 99701

sys/dev/sdhci/sdhci_fsl_fdt.c

Loading...