Add a radio group for YouTube downloads that includes a new default
run-time dependency on www/yt-dlp, a youtube-dl fork.
PR: 259944
Reported by: Oleh Vinichenko <moonlapse81@gmail.com>
Paths
| Differential D33090 Authored by jrm on Nov 23 2021, 3:29 AM.
Details Summary Add a radio group for YouTube downloads that includes a new default PR: 259944
Diff Detail
Event TimelineHerald added a subscriber: mat. · View Herald TranscriptNov 23 2021, 3:29 AM2021-11-23 03:29:39 (UTC+0) Harbormaster completed remote builds in B42928: Diff 98860.Nov 23 2021, 3:29 AM2021-11-23 03:29:40 (UTC+0) This revision is now accepted and ready to land.Nov 23 2021, 11:49 AM2021-11-23 11:49:09 (UTC+0) Comment Actions Because www/youtube-dl and www/yt-dlp cannot coexist, switch all other ports that depend on www/youtube-dl to depend on www/yt-dlp This revision now requires review to proceed.Nov 23 2021, 9:23 PM2021-11-23 21:23:17 (UTC+0) Harbormaster completed remote builds in B42942: Diff 98892.Nov 23 2021, 9:23 PM2021-11-23 21:23:29 (UTC+0) Comment Actions For multimedia/lives in description add comment about turn on SYMLINK option: YTDLP_DESC= Install yt-dlp (youtube-dl fork) - turn on SYMLINK option jrm retitled this revision from Port that depend on youtube-dl: Switch to yt-dlp to Ports that depend on youtube-dl: Switch to yt-dlp.Nov 24 2021, 1:31 AM2021-11-24 01:31:48 (UTC+0) Comment Actions www/yt-dlp: Turn the symlink option on by default If we are replacing youtube-dl with yt-dlp by default, it makes sense to turn on the symlink. Harbormaster completed remote builds in B42950: Diff 98932.Nov 24 2021, 1:32 AM2021-11-24 01:32:39 (UTC+0) Harbormaster completed remote builds in B42951: Diff 98933.Nov 24 2021, 4:05 AM2021-11-24 04:05:30 (UTC+0) This revision is now accepted and ready to land.Nov 24 2021, 4:17 AM2021-11-24 04:17:06 (UTC+0) Comment Actions I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks) Comment Actions I applied the change only to haruna (for kde@), then did pkg remove -f youtube_dl because it still got pulled in by the unchanged mpv package I have. Successfully plays videos from youtube by URL. Comment Actions
That thread mentions pytube as an alternative. However, py-pafy is required by multimedia/mps-youtube. Both are maintained by @nivit Comment Actions
I think this is an orthogonal issue that can be resolved an other time :) Comment Actions
I think we would only have to resolve this now if www/py-pafy were only broken when using www/yt-dlp and not www/youtube_dl. However, I just run-time tested multimedia/mps-youtube, py-pafy's only consumer, and it seems broken regardless which YouTube download tool py-pafy is built with. Error fetching data. Possible network issue. Youtube Error 403: The request cannot be completed because you have exceeded your <a href="/youtube/v3/getting-started#quota">quota</a>. https://github.com/mps-youtube/mps-youtube/issues/1089 My inclination is to mark py-pafy and mps-youtube as BROKEN and set some EXPIRATION. Of course, I'll wait for @nivit to comment. Maybe it's just a matter of using an appropriate API key? Comment Actions @jrm Comment Actions
VVD, are you all right with the current situation, i.e., www/yt-dlp has the SYMLINK option on by default? Do you still require a comment? Comment Actions
Yes. For those who will compile lives+yt-dlp on their own. Comment Actions Add text to multimedia/lives' YTDLP_DESC saying that it requires www/yt-dlp with SYMLINK option on This revision now requires review to proceed.Dec 6 2021, 1:55 PM2021-12-06 13:55:54 (UTC+0) Harbormaster completed remote builds in B43190: Diff 99551.Dec 6 2021, 1:55 PM2021-12-06 13:55:54 (UTC+0) This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2021, 2:57 PM2021-12-06 14:57:03 (UTC+0) Closed by commit R11:80e4e8275e9d: Ports that depend on youtube-dl: Depend on yt-dlp (authored by jrm). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Commit please fix for multimedia/lives: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260282
Revision Contents
Diff 98932 multimedia/gpodder/Makefile
multimedia/haruna/Makefile
multimedia/lives/Makefile
multimedia/mpv/Makefile
|
style(9) was recently changed to permit the braces that were here. I personally prefer the braces, especially in cases like this, where the else has braces.