Page MenuHomeFreeBSD

Ports that depend on youtube-dl: Switch to yt-dlp
ClosedPublic

Authored by jrm on Nov 23 2021, 3:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 1:29 AM
Unknown Object (File)
Feb 12 2024, 4:55 AM
Unknown Object (File)
Feb 8 2024, 10:19 PM
Unknown Object (File)
Jan 7 2024, 2:16 AM
Unknown Object (File)
Jan 7 2024, 2:13 AM
Unknown Object (File)
Jan 7 2024, 2:12 AM
Unknown Object (File)
Jan 7 2024, 2:12 AM
Unknown Object (File)
Jan 7 2024, 2:12 AM

Details

Summary

Add a radio group for YouTube downloads that includes a new default
run-time dependency on www/yt-dlp, a youtube-dl fork.

PR: 259944
Reported by: Oleh Vinichenko <moonlapse81@gmail.com>

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 42951
Build 39839: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Nov 23 2021, 3:29 AM
tcberner added a subscriber: tcberner.

Looks good to me as multimedia@ with an additional PORTREVISION bump.

This revision is now accepted and ready to land.Nov 23 2021, 11:49 AM

Because www/youtube-dl and www/yt-dlp cannot coexist, switch all other ports that depend on www/youtube-dl to depend on www/yt-dlp

This revision now requires review to proceed.Nov 23 2021, 9:23 PM
jrm retitled this revision from multimedia/mpv: Add YTDLP OPTION to Port that depend on youtube-dl: Switch to yt-dlp.Nov 23 2021, 9:25 PM
jrm added reviewers: 0mp, vvd, nivit, kde, acm, rm.

TODO: Fix www/py-pafy so tthat it recognizes www/yt-dlp during configure.

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option
jrm retitled this revision from Port that depend on youtube-dl: Switch to yt-dlp to Ports that depend on youtube-dl: Switch to yt-dlp.Nov 24 2021, 1:31 AM

www/yt-dlp: Turn the symlink option on by default

If we are replacing youtube-dl with yt-dlp by default, it makes sense to turn on the symlink.

www/py-pafy: Fix build when depending on www/yt-dlp

@nivit, does pafy run well with yt-dlp?

This revision is now accepted and ready to land.Nov 24 2021, 4:17 AM

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

I'm ok with multimedia/gpodder change

adridg added a subscriber: adridg.

I applied the change only to haruna (for kde@), then did pkg remove -f youtube_dl because it still got pulled in by the unchanged mpv package I have. Successfully plays videos from youtube by URL.

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

That thread mentions pytube as an alternative. However, py-pafy is required by multimedia/mps-youtube. Both are maintained by @nivit

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

I think this is an orthogonal issue that can be resolved an other time :)

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

I think this is an orthogonal issue that can be resolved an other time :)

I think we would only have to resolve this now if www/py-pafy were only broken when using www/yt-dlp and not www/youtube_dl. However, I just run-time tested multimedia/mps-youtube, py-pafy's only consumer, and it seems broken regardless which YouTube download tool py-pafy is built with.

Error fetching data. Possible network issue.
Youtube Error 403: The request cannot be completed because you have exceeded your <a href="/youtube/v3/getting-started#quota">quota</a>.

https://github.com/mps-youtube/mps-youtube/issues/1089

My inclination is to mark py-pafy and mps-youtube as BROKEN and set some EXPIRATION. Of course, I'll wait for @nivit to comment. Maybe it's just a matter of using an appropriate API key?

@jrm
Go ahead and mark it as deprecated (with a date) and broken. If upstream is dead there's nothing for us to do anyway.

In D33090#747847, @vvd_unislabs.com wrote:

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option

VVD, are you all right with the current situation, i.e., www/yt-dlp has the SYMLINK option on by default? Do you still require a comment?

acm and nivit, I will commit tomorrow unless I hear objections.

In D33090#752316, @jrm wrote:
In D33090#747847, @vvd_unislabs.com wrote:

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option

VVD, are all right with the current situation, i.e., www/yt-dlp has the SYMLINK option on by default? Do you still require a comment?

Yes. For those who will compile lives+yt-dlp on their own.
But after remove youtube-dl from ports and make SYMLINK option mandatory on - then we can remove this comment.

Add text to multimedia/lives' YTDLP_DESC saying that it requires www/yt-dlp with SYMLINK option on

This revision now requires review to proceed.Dec 6 2021, 1:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2021, 2:57 PM
This revision was automatically updated to reflect the committed changes.