Ports that depend on youtube-dl: Switch to yt-dlp

[jrm]

Summary

Add a radio group for YouTube downloads that includes a new default
run-time dependency on www/yt-dlp, a youtube-dl fork.

PR: 259944
Reported by: Oleh Vinichenko <[e-mail]>

[moonlapse81_gmail.com]

looks good :)

[tcberner]

Looks good to me as multimedia@ with an additional PORTREVISION bump.

[jrm]

Because www/youtube-dl and www/yt-dlp cannot coexist, switch all other ports that depend on www/youtube-dl to depend on www/yt-dlp

[jrm]

TODO: Fix www/py-pafy so tthat it recognizes www/yt-dlp during configure.

[vvd]

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option

[jrm]

www/yt-dlp: Turn the symlink option on by default

If we are replacing youtube-dl with yt-dlp by default, it makes sense to turn on the symlink.

[jrm]

www/py-pafy: Fix build when depending on www/yt-dlp

[jrm]

@nivit, does pafy run well with yt-dlp?

[diizzy]

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

[rm]

I'm ok with multimedia/gpodder change

[adridg]

I applied the change only to haruna (for kde@), then did pkg remove -f youtube_dl because it still got pulled in by the unchanged mpv package I have. Successfully plays videos from youtube by URL.

[jrm]

In D33090#747932, @diizzy wrote:

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

That thread mentions pytube as an alternative. However, py-pafy is required by multimedia/mps-youtube. Both are maintained by @nivit

[tcberner]

In D33090#747932, @diizzy wrote:

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

I think this is an orthogonal issue that can be resolved an other time :)

[jrm]

In D33090#748067, @tcberner wrote:

In D33090#747932, @diizzy wrote:

I think we should sunset py-pafy as it seems to have multiple issues and it's not maintained upstream (I haven't looked for forks)
https://github.com/mps-youtube/pafy/pull/253#issuecomment-773603467

I think this is an orthogonal issue that can be resolved an other time :)

I think we would only have to resolve this now if www/py-pafy were only broken when using www/yt-dlp and not www/youtube_dl. However, I just run-time tested multimedia/mps-youtube, py-pafy's only consumer, and it seems broken regardless which YouTube download tool py-pafy is built with.

Error fetching data. Possible network issue.
Youtube Error 403: The request cannot be completed because you have exceeded your <a href="/youtube/v3/getting-started#quota">quota</a>.

https://github.com/mps-youtube/mps-youtube/issues/1089

My inclination is to mark py-pafy and mps-youtube as BROKEN and set some EXPIRATION. Of course, I'll wait for @nivit to comment. Maybe it's just a matter of using an appropriate API key?

[diizzy]

@jrm
Go ahead and mark it as deprecated (with a date) and broken. If upstream is dead there's nothing for us to do anyway.

[jrm]

In D33090#747847, @vvd_unislabs.com wrote:

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option

VVD, are you all right with the current situation, i.e., www/yt-dlp has the SYMLINK option on by default? Do you still require a comment?

[jrm]

acm and nivit, I will commit tomorrow unless I hear objections.

[vvd]

In D33090#752316, @jrm wrote:

In D33090#747847, @vvd_unislabs.com wrote:

For multimedia/lives in description add comment about turn on SYMLINK option:

YTDLP_DESC=			Install yt-dlp (youtube-dl fork) - turn on SYMLINK option

VVD, are all right with the current situation, i.e., www/yt-dlp has the SYMLINK option on by default? Do you still require a comment?

Yes. For those who will compile lives+yt-dlp on their own.
But after remove youtube-dl from ports and make SYMLINK option mandatory on - then we can remove this comment.

[jrm]

Add text to multimedia/lives' YTDLP_DESC saying that it requires www/yt-dlp with SYMLINK option on

[vvd]

Commit please fix for multimedia/lives: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260282