Page MenuHomeFreeBSD
Differential D32688

bhyve: implement Temperature Threshold set/get feature for NVMe controller
AbandonedPublic
Actions

Authored by wanpengqian_gmail.com on Oct 27 2021, 7:52 AM.
Tags
None
Referenced Files
F151017288: D32688.diff
Sun, Apr 5, 11:46 AM
F151015684: D32688.id97525.diff
Sun, Apr 5, 11:35 AM
F151004171: D32688.id98221.diff
Sun, Apr 5, 10:13 AM
Unknown Object (File)
Sun, Apr 5, 8:27 AM
Unknown Object (File)
Sun, Apr 5, 6:46 AM
Unknown Object (File)
Sun, Apr 5, 4:15 AM
Unknown Object (File)
Fri, Apr 3, 11:37 PM
Unknown Object (File)
Fri, Apr 3, 2:11 AM
View All Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
Group Reviewers
bhyve
Summary

Temperature Threshold is a mandatory feature for NVMe controller.
when controller reset, driver will check this feature.

this patch implement these feature.

Test Plan

FreeBSD: trigger a reset event and check if dmesg output temperature threshold not supported message.
Linux: use nvme to set/get this feature.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42666
Build 39554: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Oct 27 2021, 7:52 AM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2021, 7:52 AM
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
wanpengqian_gmail.com requested review of this revision.Oct 27 2021, 7:52 AM
Harbormaster completed remote builds in B42397: Diff 97525.Oct 27 2021, 7:52 AM
wanpengqian_gmail.com updated this revision to Diff 97537.Oct 27 2021, 10:13 AM

Fix source of Threshold Type Select value.

Harbormaster completed remote builds in B42399: Diff 97537.Oct 27 2021, 10:13 AM
wanpengqian_gmail.com edited the summary of this revision. (Show Details)Oct 27 2021, 10:15 AM
wanpengqian_gmail.com edited the test plan for this revision. (Show Details)
wanpengqian_gmail.com updated this revision to Diff 97790.Nov 1 2021, 7:45 AM

Implement Set Feature for Temperature Threshold.

Harbormaster completed remote builds in B42482: Diff 97790.Nov 1 2021, 7:45 AM
wanpengqian_gmail.com retitled this revision from bhyve: implement Temperature Threshold get feature for NVMe controller to bhyve: implement Temperature Threshold set/get feature for NVMe controller.Nov 1 2021, 7:46 AM
wanpengqian_gmail.com edited the summary of this revision. (Show Details)
wanpengqian_gmail.com edited the test plan for this revision. (Show Details)
wanpengqian_gmail.com updated this revision to Diff 97791.Nov 1 2021, 7:57 AM

fix condition value.

Harbormaster completed remote builds in B42483: Diff 97791.Nov 1 2021, 7:57 AM
wanpengqian_gmail.com updated this revision to Diff 98221.Nov 9 2021, 12:37 AM

use function-like macro.

Harbormaster completed remote builds in B42666: Diff 98221.Nov 9 2021, 12:37 AM
wanpengqian_gmail.com updated this revision to Diff 98238.Nov 9 2021, 12:44 PM

create struct for each feature object

Harbormaster completed remote builds in B42672: Diff 98238.Nov 9 2021, 12:44 PM
wanpengqian_gmail.com planned changes to this revision.Aug 26 2022, 12:06 AM
wanpengqian_gmail.com abandoned this revision.Oct 19 2022, 6:26 AM
chuck removed a reviewer: chuck.Nov 10 2022, 4:46 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
108 lines

Diff 98221

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...