Page MenuHomeFreeBSD
Differential D32072

cmp: add -n, --bytes to limit number of bytes to compare
ClosedPublic
Actions

Authored by kevans on Sep 23 2021, 5:56 AM.
Tags
None
Referenced Files
F172656510: D32072.id95544.diff
Sun, Sep 20, 12:24 AM
F172656359: D32072.id95961.diff
Sun, Sep 20, 12:23 AM
F172656340: D32072.id95575.diff
Sun, Sep 20, 12:22 AM
F172656019: D32072.diff
Sun, Sep 20, 12:19 AM
Unknown Object (File)
Wed, Sep 9, 2:17 PM
Unknown Object (File)
Wed, Sep 9, 1:35 AM
Unknown Object (File)
Tue, Sep 8, 6:13 PM
Unknown Object (File)
Mon, Sep 7, 3:44 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
bapt
markj
allanjude
Group Reviewers
manpages
Commits
rG4e380e847460: cmp: add -n, --bytes to limit number of bytes to compare
Summary

This is compatible with GNU cmp.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Sep 23 2021, 5:56 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2021, 5:56 AM
Herald added a subscriber: imp. · View Herald Transcript
kevans requested review of this revision.Sep 23 2021, 5:56 AM
Harbormaster completed remote builds in B41659: Diff 95544.Sep 23 2021, 5:56 AM
kevans added a parent revision: D32071: cmp: accept SI suffixes for skip1 and skip2.Sep 23 2021, 5:56 AM
kevans added a child revision: D32073: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args.
markj accepted this revision.Sep 23 2021, 6:33 PM
markj added inline comments.
usr.bin/cmp/cmp.c
93

for consistency with handling of expand_number() errors elsewhere.

97

Cases are typically sorted, i.e., case 'n' should come after case 'l'.

usr.bin/cmp/link.c
77

We pass skip1 and skip2 as parameters to each comparison function, but limit a global var. Is there any reason it can't also be a function parameter?

This revision is now accepted and ready to land.Sep 23 2021, 6:33 PM
kevans marked 3 inline comments as done.Sep 23 2021, 6:47 PM
kevans added inline comments.
usr.bin/cmp/cmp.c
97

I fixed the sorting in the other two, as well...

kevans updated this revision to Diff 95575.Sep 23 2021, 7:15 PM
kevans marked an inline comment as done.

Address commentary

This revision now requires review to proceed.Sep 23 2021, 7:15 PM
Harbormaster completed remote builds in B41676: Diff 95575.Sep 23 2021, 7:15 PM
markj accepted this revision.Sep 29 2021, 1:58 PM
This revision is now accepted and ready to land.Sep 29 2021, 1:58 PM
Closed by commit rG4e380e847460: cmp: add -n, --bytes to limit number of bytes to compare (authored by kevans). · Explain WhySep 29 2021, 6:05 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG4e380e847460: cmp: add -n, --bytes to limit number of bytes to compare.

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
6 lines
18 lines
7 lines
6 lines
8 lines
4 lines
tests/
23 lines

Diff 95961

View Options

usr.bin/cmp/cmp.1

Loading...
View Options

usr.bin/cmp/cmp.c

Loading...
View Options

usr.bin/cmp/extern.h

Loading...
View Options

usr.bin/cmp/link.c

Loading...
View Options

usr.bin/cmp/regular.c

Loading...
View Options

usr.bin/cmp/special.c

Loading...
View Options

usr.bin/cmp/tests/cmp_test2.sh

Loading...