Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 41742 Build 38631: arc lint + arc unit
Event Timeline
BTW, gstat-rs already implements the interactive a and p keys, and it has other keys that provide the same functionality as d, o, and s. All it needs is approval from a ports committer. https://reviews.freebsd.org/D31359 .
| usr.sbin/gstat/gstat.8 | ||
|---|---|---|
| 101–102 | This isn't true. -bBCI don't work interactively. Instead, the keys that you just added should be documented in the INTERACTIVE COMMANDS section. Also, don't forget to update the date. | |
| usr.sbin/gstat/gstat.8 | ||
|---|---|---|
| 101–102 | Oops! That's true! Thanks for mentioning! Will fix now :) | |
| usr.sbin/gstat/gstat.8 | ||
|---|---|---|
| 101–102 | ||
| 107 | I'd make this description a bit cleaner. And add a period at the end for consistency. | |
| usr.sbin/gstat/gstat.c | ||
| 610 | F should go before f by convention (unless it's better to keep it the way it is now because everything else in this program is sorted this way). | |
| 615 | For consistency. | |
Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!