Page MenuHomeFreeBSD

sysutils/gstat-rs: new port
Needs ReviewPublic

Authored by asomers on Jul 30 2021, 10:24 PM.

Details

Reviewers
brd
Summary

Sponsored by: Axcient

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 41212
Build 38101: arc lint + arc unit

Event Timeline

diizzy added inline comments.
sysutils/gstat-rs/Makefile
17
105

These pkg-message lines looks out of place, any reason why you can't use the framework?
https://docs.freebsd.org/en/books/porters-handbook/book/#using-sub-files

sysutils/gstat-rs/Makefile
17

No, it is needed. Notice the difference between "gstat-rs" and "gstat".

105

I probably could use SUB_FILES. I'll try next week. I'm on vacation right now.

sysutils/gstat-rs/Makefile
17

NM; you're right.

  • Respond to diizzy's comments
sysutils/gstat-rs/files/pkg-message.in
11

What no zsh?

I would also remove the perens and capitalize For and add a colon... like:

For sh:
# echo alias..
sysutils/gstat-rs/pkg-descr
3–4

I would add all the bullet points you list in README.md in git here. That way it shows up in Freshports, etc.

sysutils/gstat-rs/files/pkg-message.in
11

What would be the right line for zsh?

sysutils/gstat-rs/files/pkg-message.in
11
echo alias gstat='/usr/local/sbin/gstat-rs' >> %%PREFIX%%/etc/zshrc
  • Add comment about zsh in pkg-message