Page MenuHomeFreeBSD

[WIP] Add more interactive mode to gstat
Needs RevisionPublic

Authored by antranigv_freebsd.am on Sep 25 2021, 12:52 AM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41743
Build 38632: arc lint + arc unit

Event Timeline

Thank you for doing this, it is very helpful.

Still needs man page etc

BTW, gstat-rs already implements the interactive a and p keys, and it has other keys that provide the same functionality as d, o, and s. All it needs is approval from a ports committer. https://reviews.freebsd.org/D31359 .

asomers requested changes to this revision.Sep 25 2021, 1:05 AM
asomers added inline comments.
usr.sbin/gstat/gstat.8
101–102

This isn't true. -bBCI don't work interactively. Instead, the keys that you just added should be documented in the INTERACTIVE COMMANDS section. Also, don't forget to update the date.

This revision now requires changes to proceed.Sep 25 2021, 1:05 AM
usr.sbin/gstat/gstat.8
101–102

Oops! That's true! Thanks for mentioning! Will fix now :)

Code changes look good. I didn't review the man pages though

0mp requested changes to this revision.Oct 5 2021, 1:59 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.sbin/gstat/gstat.8
101
107

I'd make this description a bit cleaner. And add a period at the end for consistency.

usr.sbin/gstat/gstat.c
610

F should go before f by convention (unless it's better to keep it the way it is now because everything else in this program is sorted this way).

615

For consistency.

This revision now requires changes to proceed.Oct 5 2021, 1:59 PM

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

arc patch D32130 shows that it is not changed ;-)
You need to resend it.

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

arc patch D32130 shows that it is not changed ;-)
You need to resend it.

Thank you! Will do so!