[WIP] Add more interactive mode to gstat

[allanjude]

Thank you for doing this, it is very helpful.

Still needs man page etc

[asomers]

BTW, gstat-rs already implements the interactive a and p keys, and it has other keys that provide the same functionality as d, o, and s. All it needs is approval from a ports committer. https://reviews.freebsd.org/D31359 .

[antranigv_freebsd.am]

• update manpage for gstat.8

[antranigv_freebsd.am]

• Remove the whitespace

[asomers]

usr.sbin/gstat/gstat.8

101–102

This isn't true. -bBCI don't work interactively. Instead, the keys that you just added should be documented in the INTERACTIVE COMMANDS section. Also, don't forget to update the date.

[antranigv_freebsd.am]

usr.sbin/gstat/gstat.8

101–102

Oops! That's true! Thanks for mentioning! Will fix now :)

[antranigv_freebsd.am]

• Add help menu

[antranigv_freebsd.am]

• Update date

[imp]

Code changes look good. I didn't review the man pages though

[0mp]

usr.sbin/gstat/gstat.8

101

107

I'd make this description a bit cleaner. And add a period at the end for consistency.

usr.sbin/gstat/gstat.c

610

F should go before f by convention (unless it's better to keep it the way it is now because everything else in this program is sorted this way).

615

For consistency.

[antranigv_freebsd.am]

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

[fernape]

In D32130#729265, @antranigv_freebsd.am wrote:

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

arc patch D32130 shows that it is not changed ;-)
You need to resend it.

[antranigv_freebsd.am]

In D32130#729639, @fernape wrote:

In D32130#729265, @antranigv_freebsd.am wrote:

Hey @0mp , what I did not understand is that if you already changed the code in the Diff or should I resend the patch with your changes using arc? Sorry, first time seeing this :) Let me know!

arc patch D32130 shows that it is not changed ;-)
You need to resend it.

Thank you! Will do so!