Paths

Table of Contentst

Differential D32074

cmp: add -b, --print-bytes
ClosedPublic
Actions

Authored by kevans on Sep 23 2021, 5:56 AM.

Tags

None

Referenced Files

	F171332796: D32074.id95963.diff
	Thu, Sep 10, 11:58 AM

	Unknown Object (File)
	Wed, Sep 9, 12:04 AM

	Unknown Object (File)
	Tue, Sep 8, 8:42 PM

	Unknown Object (File)
	Tue, Sep 8, 2:02 PM

	Unknown Object (File)
	Tue, Sep 8, 9:08 AM

	Unknown Object (File)
	Tue, Sep 8, 7:33 AM

	Unknown Object (File)
	Sun, Sep 6, 2:16 PM

	Unknown Object (File)
	Sun, Sep 6, 6:06 AM

Subscribers

Details

Reviewers

emaste
bapt
markj
allanjude

Group Reviewers

Commits

rGf66b9b40f403: cmp: add -b, --print-bytes

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41661
Build 38550: arc lint + arc unit

Event Timeline

kevans created this revision.Sep 23 2021, 5:56 AM

Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2021, 5:56 AM

Herald added a subscriber: imp. · View Herald Transcript

kevans requested review of this revision.Sep 23 2021, 5:56 AM

Harbormaster completed remote builds in B41661: Diff 95546.Sep 23 2021, 5:56 AM

kevans added a parent revision: D32073: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args.Sep 23 2021, 5:56 AM

markj added inline comments.Sep 23 2021, 6:47 PM

usr.bin/cmp/misc.c
66	I'm not sure how important it is to be fully compatible, but gcmp prints "byte" instead of "char".
usr.bin/cmp/regular.c
131	Why `%6o`? Isn't 3 enough? Hmm looks like this is what gcmp does.

kevans added inline comments.Sep 23 2021, 6:50 PM

usr.bin/cmp/misc.c
66	I think here it's better to just maintain internal consistency... I don't /think/ anyone's trying to parse the output.
usr.bin/cmp/regular.c
131	Right, `%6o` to be compatible with gcmp's output, but gcmp also (IIRC) had the first field only 3-wide.

markj accepted this revision.Sep 23 2021, 6:53 PM

This revision is now accepted and ready to land.Sep 23 2021, 6:53 PM

Maintain internal consistency in %b output, as well; %6o back to %3o.

This revision now requires review to proceed.Sep 23 2021, 7:18 PM

Harbormaster completed remote builds in B41677: Diff 95576.Sep 23 2021, 7:18 PM

kevans marked an inline comment as not done.Sep 23 2021, 7:18 PM

kevans marked an inline comment as done.

bapt accepted this revision.Sep 29 2021, 1:57 PM

This revision is now accepted and ready to land.Sep 29 2021, 1:57 PM

Closed by commit rGf66b9b40f403: cmp: add -b, --print-bytes (authored by kevans). · Explain WhySep 29 2021, 6:05 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGf66b9b40f403: cmp: add -b, --print-bytes.

Revision Contents
Changeset List

Path

Size

usr.bin/

cmp/

5 lines

8 lines

4 lines

10 lines

14 lines

10 lines

11 lines

tests/

5 lines

1 line

1 line

17 lines

Diff 95546

usr.bin/cmp/cmp.1

Loading...

usr.bin/cmp/cmp.c

Loading...

usr.bin/cmp/extern.h

Loading...

usr.bin/cmp/link.c

Loading...

usr.bin/cmp/misc.c

Loading...

usr.bin/cmp/regular.c

Loading...

usr.bin/cmp/special.c

Loading...

usr.bin/cmp/tests/Makefile

Loading...

usr.bin/cmp/tests/b_flag.out

Loading...

usr.bin/cmp/tests/bl_flag.out

Loading...

usr.bin/cmp/tests/cmp_test2.sh

Loading...