Page MenuHomeFreeBSD
Differential D32073

cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args
ClosedPublic
Actions

Authored by kevans on Sep 23 2021, 5:56 AM.
Tags
None
Referenced Files
F168607373: D32073.diff
Sat, Aug 29, 6:09 AM
Unknown Object (File)
Mon, Aug 24, 5:10 PM
Unknown Object (File)
Sat, Aug 22, 12:07 AM
Unknown Object (File)
Wed, Aug 19, 6:19 PM
Unknown Object (File)
Mon, Aug 17, 5:15 PM
Unknown Object (File)
Sun, Aug 16, 9:25 PM
Unknown Object (File)
Thu, Aug 13, 12:33 PM
Unknown Object (File)
Wed, Aug 12, 1:25 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
bapt
markj
allanjude
Group Reviewers
manpages
Commits
rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41660
Build 38549: arc lint + arc unit

Event Timeline

kevans created this revision.Sep 23 2021, 5:56 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2021, 5:56 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B41660: Diff 95545.Sep 23 2021, 5:56 AM
kevans requested review of this revision.Sep 23 2021, 5:56 AM
kevans added a parent revision: D32072: cmp: add -n, --bytes to limit number of bytes to compare.
kevans added a child revision: D32074: cmp: add -b, --print-bytes.
markj accepted this revision.Sep 23 2021, 6:39 PM
markj added inline comments.
usr.bin/cmp/cmp.c
86

I think this check is not needed, expand_number() will handle it.

This revision is now accepted and ready to land.Sep 23 2021, 6:39 PM
kevans marked an inline comment as done.Sep 23 2021, 6:52 PM
Closed by commit rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args (authored by kevans). · Explain WhySep 29 2021, 6:05 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG8d546b6832ee: cmp: add -i, --ignore-initial, an alternative to skip1/skip2 args.

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
19 lines
33 lines
tests/
5 lines

Diff 95545

View Options

usr.bin/cmp/cmp.1

Loading...
View Options

usr.bin/cmp/cmp.c

Loading...
View Options

usr.bin/cmp/tests/cmp_test2.sh

Loading...