Paths

Table of Contentst

Differential D31777

mprotect.2: Improve the description of prot
ClosedPublic
Actions

Authored by brooks on Sep 1 2021, 9:28 PM.

Tags

None

Referenced Files

	F171117767: D31777.diff
	Tue, Sep 8, 7:41 PM

	Unknown Object (File)
	Sun, Sep 6, 3:30 PM

	Unknown Object (File)
	Sun, Sep 6, 10:18 AM

	Unknown Object (File)
	Sun, Sep 6, 5:50 AM

	Unknown Object (File)
	Sun, Sep 6, 2:03 AM

	Unknown Object (File)
	Sat, Sep 5, 11:08 PM

	Unknown Object (File)
	Sat, Sep 5, 11:02 PM

	Unknown Object (File)
	Sat, Sep 5, 4:35 PM

Subscribers

Details

Reviewers

kib
alc
mckusick
markj
imp

Group Reviewers

Commits

rG85bea309f935: mprotect.2: Improve the description of prot

Summary

The new wording is based on the POSIX description.

Sponsored by: DARPA

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41341
Build 38230: arc lint + arc unit

Event Timeline

brooks created this revision.Sep 1 2021, 9:28 PM

Herald added a reviewer: manpages. · View Herald TranscriptSep 1 2021, 9:28 PM

Herald added a subscriber: imp. · View Herald Transcript

brooks requested review of this revision.Sep 1 2021, 9:28 PM

brooks added a parent revision: D31776: mprotect.2: Remove legacy BSD text.

Harbormaster completed remote builds in B41321: Diff 94520.Sep 1 2021, 9:29 PM

As requested in D30442, this improves the wording of the description of the prot argument.

The wording is much better, and I don't think changes the intended meaning...

This revision is now accepted and ready to land.Sep 1 2021, 9:33 PM

kib accepted this revision.Sep 1 2021, 11:07 PM

markj added inline comments.Sep 2 2021, 2:58 PM

lib/libc/sys/mprotect.2
59–60	Technically, the argument should be the bitwise OR of some subset of {READ, WRITE, EXEC} or PROT_NONE. ORing PROT_NONE with other flags does nothing.

Separate PROT_NONE from other arguments

This revision now requires review to proceed.Sep 2 2021, 6:47 PM

Harbormaster completed remote builds in B41335: Diff 94572.Sep 2 2021, 6:47 PM

brooks marked an inline comment as done.Sep 2 2021, 6:47 PM

alc accepted this revision.Sep 2 2021, 9:09 PM

This revision is now accepted and ready to land.Sep 2 2021, 9:09 PM

markj accepted this revision.Sep 2 2021, 9:11 PM

markj added inline comments.

lib/libc/sys/mprotect.2
54

alc added inline comments.Sep 2 2021, 9:20 PM

lib/libc/sys/mprotect.2
75–76	While we're here, I would suggest adding the word "later" here, i.e., saying, "... from later upgrading ..." Also, wouldn't "adding" be clearer than "upgrading"?
78	Add the word "bitwise" here, like above?

I agree with mark and alc comments.

Adopt reviewer suggestions
Render "or" consistently

This revision now requires review to proceed.Sep 2 2021, 11:53 PM

Harbormaster completed remote builds in B41341: Diff 94584.Sep 2 2021, 11:53 PM

brooks marked 3 inline comments as done.Sep 2 2021, 11:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 7 2021, 4:29 PM

Closed by commit rG85bea309f935: mprotect.2: Improve the description of prot (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG85bea309f935: mprotect.2: Improve the description of prot.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

21 lines

Diff 94584

lib/libc/sys/mprotect.2

Loading...