Page MenuHomeFreeBSD

pvclock: Add vDSO support
ClosedPublic

Authored by adam_fenn.io on Aug 5 2021, 2:29 AM.
Tags
None
Referenced Files
F125719815: D31418.id93247.diff
Mon, Aug 11, 6:18 AM
Unknown Object (File)
Mon, Aug 4, 2:07 AM
Unknown Object (File)
Fri, Aug 1, 8:10 PM
Unknown Object (File)
Fri, Jul 25, 10:14 AM
Unknown Object (File)
Tue, Jul 22, 7:41 AM
Unknown Object (File)
Thu, Jul 17, 5:45 AM
Unknown Object (File)
Sun, Jul 13, 10:32 AM
Unknown Object (File)
Jul 10 2025, 12:43 PM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40879
Build 37768: arc lint + arc unit

Event Timeline

adam_fenn.io held this revision as a draft.
sys/x86/x86/pvclock.c
150

Should it (formally) be atomic_cmpset_rel_64?

153

Could this be written more simply as:

ret = now;
if ((flags & PVCLOCK_FLAG_TSC_STABLE) == 0) {
    last = atomic_load_acq_64(&pvclock_last_systime);
    do {
        if (last > now) {
            ret = last;
            break;
        }
    } while (!atomic_fcmpset_64(&pvclock_last_systime, &last, now);
}

?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2021, 12:59 PM
Closed by commit rG0b3382b863f3: pvclock: Add 'struct pvclock' API (authored by adam_fenn.io, committed by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.