Page MenuHomeFreeBSD
Differential D31341

nvme/nda: Fail all nvme I/Os after controller fails
ClosedPublic
Actions

Authored by imp on Jul 28 2021, 10:33 PM.
Tags
None
Referenced Files
F161384139: D31341.id.diff
Fri, Jul 3, 7:39 AM
F161372106: D31341.id93147.diff
Fri, Jul 3, 5:48 AM
F161369527: D31341.id95325.diff
Fri, Jul 3, 5:24 AM
F161335563: D31341.id92909.diff
Thu, Jul 2, 10:37 PM
F161309922: D31341.id.diff
Thu, Jul 2, 4:13 PM
Unknown Object (File)
Thu, Jul 2, 12:24 AM
Unknown Object (File)
Sat, Jun 27, 9:11 AM
Unknown Object (File)
Mon, Jun 22, 1:42 PM
View All Files
Subscribers
dab

Details

Reviewers
mav
chuck
Commits
rG24d2d1813e82: nvme/nda: Fail all nvme I/Os after controller fails
rG4b977e6dda92: nvme/nda: Fail all nvme I/Os after controller fails
Summary

Once the controller has failed, fail all I/O w/o sending it to the
device. The reset of the nvme driver won't schedule any I/O to the
failed device, and the controller is in an indeterminate state and can't
accept I/O. Fail both at the top end of the sim and the bottom
end. Don't bother queueing up the I/O for failure in a different task.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40815
Build 37704: arc lint + arc unit

Event Timeline

imp created this revision.Jul 28 2021, 10:33 PM
Herald added a subscriber: dab. · View Herald TranscriptJul 28 2021, 10:33 PM
imp requested review of this revision.Jul 28 2021, 10:33 PM
Harbormaster completed remote builds in B40735: Diff 92909.Jul 28 2021, 10:33 PM
imp added reviewers: mav, chuck.Jul 28 2021, 10:33 PM
chuck added inline comments.Jul 31 2021, 2:59 PM
sys/dev/nvme/nvme_qpair.c
1076–1077

Should this comment get updated as nvme_qpair_manual_complete_request() isn't posting to a task?

sys/dev/nvme/nvme_sim.c
262

I'm not seeing a definition for CAM_REQ_DEV_NOT_THERE. Should this be CAM_DEV_NOT_THERE?

imp updated this revision to Diff 93147.Aug 2 2021, 10:13 PM

update per review / chuck

Harbormaster completed remote builds in B40815: Diff 93147.Aug 2 2021, 10:13 PM
imp marked 2 inline comments as done.Aug 2 2021, 10:15 PM
chuck accepted this revision.Aug 2 2021, 10:52 PM
This revision is now accepted and ready to land.Aug 2 2021, 10:52 PM
mav added inline comments.Aug 3 2021, 3:04 AM
sys/dev/nvme/nvme_sim.c
264

It is not a problem, but is it really needed?

Closed by commit rG4b977e6dda92: nvme/nda: Fail all nvme I/Os after controller fails (authored by imp). · Explain WhySep 17 2021, 10:14 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG4b977e6dda92: nvme/nda: Fail all nvme I/Os after controller fails.
mav added a commit: rG24d2d1813e82: nvme/nda: Fail all nvme I/Os after controller fails.Jan 21 2022, 2:27 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
8 lines
4 lines

Diff 93147

View Options

sys/dev/nvme/nvme_qpair.c

Loading...
View Options

sys/dev/nvme/nvme_sim.c

Loading...