Page MenuHomeFreeBSD
Differential D31230

init: execute /etc/rc.final after all user processes have terminated
ClosedPublic
Actions

Authored by kevans on Jul 20 2021, 11:48 AM.
Tags
None
Referenced Files
F169245773: D31230.id92610.diff
Tue, Sep 1, 1:21 AM
F169113368: D31230.id92666.diff
Mon, Aug 31, 11:05 AM
Unknown Object (File)
Mon, Aug 31, 12:03 AM
Unknown Object (File)
Sun, Aug 30, 9:09 PM
Unknown Object (File)
Sun, Aug 30, 2:55 PM
Unknown Object (File)
Fri, Aug 28, 8:21 PM
Unknown Object (File)
Thu, Aug 27, 6:49 PM
Unknown Object (File)
Wed, Aug 26, 7:15 PM
View All Files
Subscribers
gbe
imp

Details

Reviewers
trasz
mhorne
kib
brooks
Group Reviewers
manpages
Commits
rG4d1597691916: init: execute /etc/rc.final after all user processes have terminated
Summary

This can be useful for, e.g., unmounting filesystems that were needed
for shutdown.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #63

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40615
Build 37504: arc lint + arc unit

Event Timeline

kevans created this revision.Jul 20 2021, 11:48 AM
Herald added a reviewer: manpages. · View Herald TranscriptJul 20 2021, 11:48 AM
Herald added a subscriber: imp. · View Herald Transcript
kevans requested review of this revision.Jul 20 2021, 11:48 AM
Harbormaster completed remote builds in B40549: Diff 92484.Jul 20 2021, 11:48 AM
gbe accepted this revision as: manpages.Jul 20 2021, 11:52 AM
gbe added a subscriber: gbe.

LGTM for the man page part.

kib added inline comments.Jul 20 2021, 2:41 PM
sbin/init/init.c
2061

I suggest to also check that +x bit it enabled

2077

s/ 0/NULL/ ? And perhaps without the cast?

2080

may be, say which file you execed so user understand why execl failed.

2085

Again, NULL instead of (int *)0?

kevans updated this revision to Diff 92610.Jul 21 2021, 9:41 PM
kevans marked 4 inline comments as done.

Address feedback from kib

Harbormaster completed remote builds in B40615: Diff 92610.Jul 21 2021, 9:41 PM
kevans added inline comments.Jul 21 2021, 9:54 PM
sbin/init/init.c
2061

Tossed in a warning() if it exists as non-executable

kib accepted this revision.Jul 21 2021, 10:05 PM
This revision is now accepted and ready to land.Jul 21 2021, 10:05 PM
Closed by commit rG4d1597691916: init: execute /etc/rc.final after all user processes have terminated (authored by kevans). · Explain WhyJul 23 2021, 4:27 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG4d1597691916: init: execute /etc/rc.final after all user processes have terminated.

Revision Contents
Changeset List

PathSize
sbin/
init/
17 lines
51 lines
1 line

Diff 92610

View Options

sbin/init/init.8

Loading...
View Options

sbin/init/init.c

Loading...
View Options

sbin/init/pathnames.h

Loading...