Page MenuHomeFreeBSD
Differential D27532

net/rabbitmq: update to 3.8.18 and OTP24 with jit support
AbandonedPublic
Actions

Authored by dch on Dec 10 2020, 9:36 AM.
Tags
Referenced Files
F122022888: D27532.id91442.diff
Tue, Jul 1, 1:12 PM
Unknown Object (File)
Mon, Jun 30, 4:32 AM
Unknown Object (File)
Sun, Jun 29, 2:11 PM
Unknown Object (File)
Fri, Jun 27, 5:26 PM
Unknown Object (File)
Wed, Jun 25, 8:52 AM
Unknown Object (File)
Wed, Jun 25, 1:30 AM
Unknown Object (File)
Tue, Jun 24, 4:39 AM
Unknown Object (File)
Mon, Jun 23, 7:00 AM
View All Files
Subscribers
dumbbell
mat

Details

Reviewers
None
Group Reviewers
Erlang
Summary

RabbitMQ has moved to a much tighter cycle of support, now that the
Erlang OTP team has also made clear their support policy is penultimate
+ current release only.

Now we have OTP24 in ports let's move to that because JIT.

  • PATH leakage fixed
  • linuxisms for /var/db/rabbitmq fixed
  • rc.d works
  • man pages use hier(7) paths

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 40145
Build 37034: arc lint + arc unit

Event Timeline

dch created this revision.Dec 10 2020, 9:36 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 10 2020, 9:36 AM
dch requested review of this revision.Dec 10 2020, 9:36 AM
Harbormaster completed remote builds in B35288: Diff 80502.Dec 10 2020, 9:36 AM
dch added a comment.Dec 10 2020, 9:47 AM
  • PATH needs to have erlang23/bin prepended in all the usual places
  • HOMEDIR isn't being set properly with the amended scripts
dch updated this revision to Diff 80507.Dec 10 2020, 10:15 AM
  • o tiny cuttlefish, we miss you
  • fix more /var/lib/rabbitmq linuxisms
Harbormaster completed remote builds in B35289: Diff 80507.Dec 10 2020, 10:15 AM
dch updated this revision to Diff 80508.Dec 10 2020, 10:32 AM
  • fix ERL_DIR diff
Harbormaster completed remote builds in B35290: Diff 80508.Dec 10 2020, 10:32 AM
dch updated this revision to Diff 80509.Dec 10 2020, 10:46 AM
  • more ERL_DIR path injection
Harbormaster completed remote builds in B35291: Diff 80509.Dec 10 2020, 10:46 AM
dch updated this revision to Diff 80510.Dec 10 2020, 11:29 AM

drop cuttlefish binary it has been superceded

Harbormaster completed remote builds in B35292: Diff 80510.Dec 10 2020, 11:29 AM
dch updated this revision to Diff 80511.Dec 10 2020, 11:54 AM
  • damn you cuttlefish hiding in so many crevices
Harbormaster completed remote builds in B35293: Diff 80511.Dec 10 2020, 11:54 AM
dch updated this revision to Diff 80514.Dec 10 2020, 1:08 PM

addressed HOMEDIR issue via RABBITMQ_MNESIA_BASE

Harbormaster completed remote builds in B35295: Diff 80514.Dec 10 2020, 1:08 PM
dumbbell added a subscriber: dumbbell.EditedDec 14 2020, 10:51 AM

Hi!

After seeing the significant amount of patching being done to tune the defaults to FreeBSD file hierarchy, I believe it would be way easier to install a ${LOCALBASE}/etc/rabbitmq/rabbitmq-env.conf file instead. The only patch required would be setting SYS_PREFIX in rabbitmq-defaults.

Then, the content of rabbitmq-env.conf would be:

# rabbitmq user's home.
HOME=/var/db/rabbitmq

# Adjust $PATH to default to Erlang 23.
PATH=${LOCALBASE}/lib/erlang23/bin:$PATH

# Data & log files locations.
RABBITMQ_MNESIA_BASE=${HOME}/mnesia
RABBITMQ_LOG_BASE=/var/log/rabbitmq

What do you think?

dch added a comment.Jan 11 2021, 10:21 AM
In D27532#616893, @dumbbell wrote:

Hi!

After seeing the significant amount of patching being done to tune the defaults to FreeBSD file hierarchy, I believe it would be way easier to install a ${LOCALBASE}/etc/rabbitmq/rabbitmq-env.conf file instead. The only patch required would be setting SYS_PREFIX in rabbitmq-defaults.

Then, the content of rabbitmq-env.conf would be:

# rabbitmq user's home.
HOME=/var/db/rabbitmq

# Adjust $PATH to default to Erlang 23.
PATH=${LOCALBASE}/lib/erlang23/bin:$PATH

# Data & log files locations.
RABBITMQ_MNESIA_BASE=${HOME}/mnesia
RABBITMQ_LOG_BASE=/var/log/rabbitmq

What do you think?

this is 10x better, yes thanks! how can we handle the very common situation
of a rabbitmq-env.conf already existing, that wouldn't have these settings?

dch updated this revision to Diff 91343.Jun 25 2021, 12:13 PM

port builds, using OTP23 as baseline but runtime PATH for /var/db/rabbitmq
still defaults incorrectly to /var/lib/rabbitmq. further debugging needed.

Harbormaster completed remote builds in B40089: Diff 91343.Jun 25 2021, 12:14 PM
dch retitled this revision from net/rabbitmq: update to 3.8.9 and latest OTP23 to net/rabbitmq: update to 3.8.18 and OTP24 with jit support.Jun 26 2021, 3:19 PM
dch edited the summary of this revision. (Show Details)
dch edited the test plan for this revision. (Show Details)
dch added a reviewer: Erlang.
dch added a project: Erlang.
dch updated this revision to Diff 91429.Jun 28 2021, 9:35 AM

OTP24

Harbormaster completed remote builds in B40138: Diff 91429.Jun 28 2021, 9:35 AM
dch updated this revision to Diff 91430.Jun 28 2021, 9:40 AM

remove PATH tweaks in favour of SYS_PREFIX introduced in 3.8.4

Harbormaster completed remote builds in B40139: Diff 91430.Jun 28 2021, 9:40 AM
dch updated this revision to Diff 91434.Jun 28 2021, 10:58 AM

fix path handling
fix directory location

Harbormaster completed remote builds in B40141: Diff 91434.Jun 28 2021, 10:58 AM
dch edited the summary of this revision. (Show Details)Jun 28 2021, 11:14 AM
dch updated this revision to Diff 91437.Jun 28 2021, 12:37 PM

resolve rc.d script issues in start|stop|status

Harbormaster completed remote builds in B40142: Diff 91437.Jun 28 2021, 12:37 PM
dch updated this revision to Diff 91438.Jun 28 2021, 12:47 PM

ensure HOME is set as su -m does not acquire this from GECOS info

Harbormaster completed remote builds in B40143: Diff 91438.Jun 28 2021, 12:47 PM
dch updated this revision to Diff 91442.Jun 28 2021, 3:25 PM

align man pages with hier(7)

Harbormaster completed remote builds in B40145: Diff 91442.Jun 28 2021, 3:25 PM
dch edited the summary of this revision. (Show Details)Jun 28 2021, 3:27 PM
dch updated this revision to Diff 91492.Jun 29 2021, 10:42 AM
  • add permissions for /usr/local/etc/rabbitmq so they are writable by scripts
  • force locale in rabbitmq-defaults so that all scripts inherit this
Harbormaster completed remote builds in B40159: Diff 91492.Jun 29 2021, 10:42 AM
dch abandoned this revision.Feb 23 2022, 10:00 AM

overcome by events

Revision Contents
Changeset List

Diff 91442

View Options

net/rabbitmq/Makefile

Loading...
View Options

net/rabbitmq/distinfo

Loading...
View Options

net/rabbitmq/files/patch-deps_rabbit_scripts_rabbitmq-defaults.in

Loading...
View Options

net/rabbitmq/files/patch-deps_rabbit_scripts_rabbitmq-plugins

Loading...
View Options

net/rabbitmq/files/patch-deps_rabbit_scripts_rabbitmq-server

Loading...
View Options

net/rabbitmq/files/patch-deps_rabbit_scripts_rabbitmqctl

Loading...
View Options

net/rabbitmq/files/patch-deps_rabbitmq__cli_mix.exs

Loading...
View Options

net/rabbitmq/files/rabbitmq.in

Loading...
View Options

net/rabbitmq/pkg-plist

Loading...