Page MenuHomeFreeBSD

linux(4): Fixup the vDSO initialization order.
ClosedPublic

Authored by dchagin on Jun 25 2021, 4:00 PM.
Tags
None
Referenced Files
F146491894: D30902.diff
Tue, Mar 3, 3:08 AM
Unknown Object (File)
Sun, Mar 1, 12:13 AM
Unknown Object (File)
Fri, Feb 27, 4:06 PM
Unknown Object (File)
Fri, Feb 27, 1:44 PM
Unknown Object (File)
Sun, Feb 22, 12:27 AM
Unknown Object (File)
Fri, Feb 20, 5:49 PM
Unknown Object (File)
Sun, Feb 8, 9:23 AM
Unknown Object (File)
Sun, Feb 8, 8:28 AM
Subscribers

Details

Summary

The vDSO initialisation order should be as follows:

  • native abi init via exec_sysvec_init();
  • vDSO symbols queued to the linux_vdso_syms list;
  • linux_vdso_install();
  • linux_exec_sysvec_init();

As the exec_sysvec_init() called with SI_ORDER_ANY (last) at SI_SUB_EXEC
order, move linux_vdso_install() and linux_exec_sysvec_init() to the
SI_SUB_EXEC+1 order.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40103
Build 36992: arc lint + arc unit

Event Timeline

sys/amd64/linux/linux_sysvec.c
828

Since the + 1 carries no context I think it would be worth a comment, e.g. mentioning that exec_sysvec_init is SI_SUB_EXEC and this must be after?

This revision is now accepted and ready to land.Jul 9 2021, 2:02 PM