imgact_elf: compute auxv buffer size instead of using magic value
ClosedPublic
Actions

Authored by trasz on Jun 19 2021, 11:42 AM.

Details

Reviewers

kib
imp

Commits

rG392611f28695: imgact_elf: compute auxv buffer size instead of using magic value
rG06250515cff5: imgact_elf: compute auxv buffer size instead of using magic value

Summary

The new buffer is somewhat larger, but there should
be no functional changes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39989
Build 36878: arc lint + arc unit

Event Timeline

trasz created this revision.Jun 19 2021, 11:42 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2021, 11:42 AM

trasz requested review of this revision.Jun 19 2021, 11:42 AM

Harbormaster completed remote builds in B39989: Diff 91089.Jun 19 2021, 11:42 AM

imp accepted this revision.Jun 19 2021, 1:49 PM

This revision is now accepted and ready to land.Jun 19 2021, 1:49 PM

Note that in theory, application might replace its auxv vector with whatever values it wants. So proc_getauxv() does not limit the count to AT_COUNT, but defined somewhat arbitrary PROC_AUXV_MAX limit. You might move this define to some global place and use it instead of AT_COUNT, as a follow-up.

Anyway, this change is already an improvement, since it avoids truncating auxv for normal core dumps.

(Tinderboxed.)

Closed by commit rG06250515cff5: imgact_elf: compute auxv buffer size instead of using magic value (authored by trasz). · Explain WhyJun 21 2021, 4:07 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG06250515cff5: imgact_elf: compute auxv buffer size instead of using magic value.

jhb added a commit: rG392611f28695: imgact_elf: compute auxv buffer size instead of using magic value.May 12 2022, 10:57 PM