bhyve vtblk: Inform guests of disk resize events.
ClosedPublic
Actions

Authored by jhb on May 27 2021, 1:25 PM.

Details

Reviewers

grehan
markj

Group Reviewers

bhyve

Commits

rG86139cc75a55: bhyve vtblk: Inform guests of disk resize events.
rG2349cda44fea: bhyve vtblk: Inform guests of disk resize events.

Summary

Register a resize callback with the blockif interface. When the
callback fires, update the size of the disk and notify the guest via a
configuration change interrupt.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 27 2021, 1:25 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMay 27 2021, 1:25 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.May 27 2021, 1:25 PM

jhb added a parent revision: D30505: bhyve: Split out a lower-level helper for VirtIO interrupts..

Harbormaster completed remote builds in B39510: Diff 90003.May 27 2021, 1:25 PM

markj accepted this revision as: markj.Jun 2 2021, 4:11 PM

This revision is now accepted and ready to land.Jun 2 2021, 4:11 PM

grehan accepted this revision.Jun 3 2021, 1:03 PM

grehan added inline comments.

usr.sbin/bhyve/pci_virtio_block.c
446	Does the lock need to be taken here ?

jhb added inline comments.Jun 4 2021, 6:26 PM

usr.sbin/bhyve/pci_virtio_block.c
446	Does the lock need to be taken here ? I only did it to protect vbc_capacity, but if the lock isn't held when reading that field then it isn't doing much good. Hmm, I guess if we cared about the race we would need to grab the lock again in pci_vtblk_cfgread()? Maybe the race is such that we don't care? Or if cfg reads are rare, maybe it doesn't hurt to be paranoid and lock in the read?