fstyp(8): define HAVE_ZFS macro when built with zfs
ClosedPublic
Actions

Authored by rew on May 12 2021, 3:17 AM.

Details

Reviewers

Commits

rG3c17cf307b01: bhyve/snapshot: provide a way to send other messages/data to bhyve
rG942e69146ea2: fstyp(8): define HAVE_ZFS macro when built with zfs
rG91f251b2ab3a: fstyp(8): define HAVE_ZFS macro when built with zfs

Summary

The HAVE_ZFS macro was dropped from the Makefile during the OpenZFS
merge, bring it back.

PR: 255616
Reported by: Michael Büker <freebsd@michael-bueker.de>
Submitted by: Michael Büker <freebsd@michael-bueker.de>
Fixes: 9e5787d2284e187abb5b654d924394a65772e004

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39132
Build 36021: arc lint + arc unit

Event Timeline

rew created this revision.May 12 2021, 3:17 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 12 2021, 3:17 AM

rew requested review of this revision.May 12 2021, 3:17 AM

Harbormaster completed remote builds in B39132: Diff 89057.May 12 2021, 3:17 AM

rew added a reviewer: trasz.May 12 2021, 3:18 AM

rew retitled this revision from fstype(8): define HAVE_ZFS macro when built with zfs to fstyp(8): define HAVE_ZFS macro when built with zfs.May 12 2021, 3:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2021, 1:34 AM

Closed by commit rGd4870e3a7256: bhyve/snapshot: provide a way to send other messages/data to bhyve (authored by rew). · Explain Why

This revision was automatically updated to reflect the committed changes.

rew added a commit: rGd4870e3a7256: bhyve/snapshot: provide a way to send other messages/data to bhyve.

Herald added a reviewer: bhyve. · View Herald TranscriptMay 13 2021, 1:34 AM

Herald added subscribers: bcran, rgrimes. · View Herald Transcript

rew removed a reviewer: bhyve.May 13 2021, 1:44 AM

rew removed rG FreeBSD src repository as the repository for this revision.

rew removed subscribers: rgrimes, bcran.

rew removed a commit: rGd4870e3a7256: bhyve/snapshot: provide a way to send other messages/data to bhyve.May 13 2021, 6:05 AM

rew removed reviewers: cem, trasz.May 13 2021, 6:19 AM

rew reopened this revision.May 13 2021, 6:29 AM

previous diff was an error, this is the correct diff.

Harbormaster completed remote builds in B39156: Diff 89110.May 13 2021, 6:31 AM

markj accepted this revision.May 13 2021, 12:37 PM

markj added a subscriber: markj.

markj added inline comments.

usr.sbin/fstyp/Makefile
31–32	BTW, this line doesn't appear to be needed at least on amd64.

This revision is now accepted and ready to land.May 13 2021, 12:37 PM

rew added inline comments.May 14 2021, 8:23 AM

usr.sbin/fstyp/Makefile
31–32	Since you point it out, I notice that it appears to be unused. WARNS is already set to 2 farther up (line 15). I'll remove this line on commit if there's no objection.