Page MenuHomeFreeBSD

e1000: Clean up igb_txrx
ClosedPublic

Authored by kbowling on May 1 2021, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:09 AM
Unknown Object (File)
Feb 8 2024, 11:11 PM
Unknown Object (File)
Dec 22 2023, 2:24 AM
Unknown Object (File)
Dec 12 2023, 2:33 AM
Unknown Object (File)
Nov 4 2023, 9:07 AM
Unknown Object (File)
Oct 31 2023, 1:04 AM
Unknown Object (File)
Oct 8 2023, 7:01 PM
Unknown Object (File)
Aug 10 2023, 4:33 PM
Subscribers
None

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kbowling created this revision.
sys/dev/e1000/igb_txrx.c
530

Maybe this is also worth a __predict_false()

534

I would not use a __predict here, as there is no v6 l3 checksum, so I assume that v6 packets would take the unpredicted path, and be penalized.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

Looks ok to me aside from the comments.

sys/dev/e1000/igb_txrx.c
494

This assignment isn't needed.

544

Indentation here should be by four spaces.

This revision is now accepted and ready to land.May 10 2021, 2:52 PM