Page MenuHomeFreeBSD

e1000: Clean up igb_txrx
ClosedPublic

Authored by kbowling on May 1 2021, 11:34 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

kbowling created this revision.
sys/dev/e1000/igb_txrx.c
530

Maybe this is also worth a __predict_false()

534

I would not use a __predict here, as there is no v6 l3 checksum, so I assume that v6 packets would take the unpredicted path, and be penalized.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

Looks ok to me aside from the comments.

sys/dev/e1000/igb_txrx.c
495

This assignment isn't needed.

543

Indentation here should be by four spaces.

This revision is now accepted and ready to land.May 10 2021, 2:52 PM