pf: Support killing 'matching' states
ClosedPublic
Actions

Authored by kp on May 3 2021, 2:51 PM.

Details

Reviewers

None

Group Reviewers

network
manpages

Commits

rG8c610ccac621: pf: Support killing 'matching' states
rG21449c5c1eee: pf: Support killing 'matching' states
rG93abcf17e6cf: pf: Support killing 'matching' states

Summary

Optionally also kill states that match (i.e. are the NATed state or
opposite direction state entry for) the state we're killing.

Submitted by: Steven Brown
Obtained from: https://github.com/pfsense/FreeBSD-src/pull/11/
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38984
Build 35873: arc lint + arc unit

Event Timeline

kp created this revision.May 3 2021, 2:51 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 3 2021, 2:51 PM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald Transcript

kp requested review of this revision.May 3 2021, 2:51 PM

Harbormaster completed remote builds in B38982: Diff 88540.May 3 2021, 2:51 PM

kp added a child revision: D30093: pf tests: Test killing matching states.May 3 2021, 2:51 PM

kp added a parent revision: D30059: pf tests: Test killing states by gateway.May 3 2021, 2:52 PM

Minor man page nit.

sbin/pfctl/pfctl.8
340	Line break after the sentence stop needed here.

Man page nit

Harbormaster completed remote builds in B38984: Diff 88545.May 3 2021, 3:32 PM

Manpage looks good now.
I guess upstream will incorporate it, too.

In D30092#675436, @bcr wrote:

I guess upstream will incorporate it, too.

We are upstream. The patch was originally submitted against pfsense, but we're the pfsense upstream, so they'll get it as part of their usual sync operations.

Right, I thought it was the other way around, but this makes more sense. :-)

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2021, 8:15 PM

Closed by commit rG93abcf17e6cf: pf: Support killing 'matching' states (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG93abcf17e6cf: pf: Support killing 'matching' states.

kp added a commit: rG21449c5c1eee: pf: Support killing 'matching' states.May 14 2021, 1:07 PM

kp added a commit: rG8c610ccac621: pf: Support killing 'matching' states.