Page MenuHomeFreeBSD
Differential D29187

LinuxKPI: add support for crc32_le()
ClosedPublic
Actions

Authored by bz on Mar 10 2021, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 28, 8:38 PM
Unknown Object (File)
Wed, May 22, 3:18 AM
Unknown Object (File)
Sat, May 11, 6:24 AM
Unknown Object (File)
Fri, May 10, 2:05 AM
Unknown Object (File)
Mon, May 6, 3:44 PM
Unknown Object (File)
May 2 2024, 2:06 PM
Unknown Object (File)
Apr 26 2024, 9:20 AM
Unknown Object (File)
Apr 25 2024, 1:50 PM
View All 37 Files
Subscribers
emaste
• hselasky
imp
kib
manu

Details

Reviewers
tuexen
arichardson
markj
kib
• hselasky
Group Reviewers
linuxkpi
Commits
rGb3096b49f97e: LinuxKPI: add support for crc32_le()
rG0c7b75f12840: LinuxKPI: add support for crc32_le()
Summary
Add support for crc32_le() as a wrapper around crc32_raw().

Sponsored-by:	The FreeBSD Foundation
Obtained-from:	bz_iwlwifi
MFC after:	2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37739
Build 34628: arc lint + arc unit

Event Timeline

bz created this revision.Mar 10 2021, 3:13 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 10 2021, 3:13 PM
bz requested review of this revision.Mar 10 2021, 3:13 PM
Harbormaster completed remote builds in B37728: Diff 85483.Mar 10 2021, 3:13 PM
bz added a comment.Mar 10 2021, 3:14 PM

I added some of you as reviewers as you have lately touched the crc32 code and I'd love a separate pair of eyes confirming that byte order for this is correct.

bz added reviewers: kib, • hselasky.Mar 10 2021, 3:15 PM
bz added subscribers: • hselasky, kib.

Add @kib and @hselasky as I still cannot see you as memebers of linuxkpi?

manu added a subscriber: manu.Mar 10 2021, 3:21 PM
manu added inline comments.
sys/compat/linuxkpi/common/include/linux/crc32.h
31

s/LINUC/LINUX/

• hselasky added inline comments.Mar 10 2021, 7:32 PM
sys/compat/linuxkpi/common/include/linux/crc32.h
31

LINUC -> LINUX

bz updated this revision to Diff 85504.Mar 10 2021, 7:41 PM

Try to correcctellyy spell1lll LUNIX.

Harbormaster completed remote builds in B37739: Diff 85504.Mar 10 2021, 7:41 PM
• hselasky accepted this revision.Mar 10 2021, 8:17 PM
This revision is now accepted and ready to land.Mar 10 2021, 8:17 PM
Closed by commit rG0c7b75f12840: LinuxKPI: add support for crc32_le() (authored by bz). · Explain WhyMar 18 2021, 11:06 AM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG0c7b75f12840: LinuxKPI: add support for crc32_le().
bz added a commit: rGb3096b49f97e: LinuxKPI: add support for crc32_le().Jul 18 2021, 12:36 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
42 lines

Diff 85504

View Options

sys/compat/linuxkpi/common/include/linux/crc32.h

Loading...