Page MenuHomeFreeBSD
Differential D29091

Improve test messages for msun tests
ClosedPublic
Actions

Authored by arichardson on Mar 5 2021, 4:34 PM.
Tags
None
Referenced Files
F167625945: D29091.id.diff
Sun, Aug 23, 7:08 AM
F167621778: D29091.diff
Sun, Aug 23, 6:04 AM
Unknown Object (File)
Sat, Aug 22, 3:18 AM
Unknown Object (File)
Fri, Aug 21, 5:03 PM
Unknown Object (File)
Fri, Aug 21, 4:49 PM
Unknown Object (File)
Fri, Aug 21, 4:48 PM
Unknown Object (File)
Sat, Aug 15, 6:30 PM
Unknown Object (File)
Sat, Aug 15, 6:15 PM
View All Files
Subscribers
imp

Details

Reviewers
ngie
dim
lwhsu
Commits
rGbc04f427f54f: Improve test messages for msun tests
rGb424e0038a00: Improve test messages for msun tests
Summary

Also print the mismatched values when numbers compare not equal.

Depends on D28798

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37614
Build 34503: arc lint + arc unit

Event Timeline

arichardson created this revision.Mar 5 2021, 4:34 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2021, 4:34 PM
arichardson requested review of this revision.Mar 5 2021, 4:34 PM
Harbormaster completed remote builds in B37613: Diff 85216.Mar 5 2021, 4:34 PM
arichardson added a child revision: D29076: Fix lib/msun/tests/csqrt_test on platforms with 128-bit long double.Mar 5 2021, 4:36 PM
arichardson mentioned this in D29076: Fix lib/msun/tests/csqrt_test on platforms with 128-bit long double.
arichardson updated this revision to Diff 85220.Mar 5 2021, 4:38 PM

Remove unrelated makefile change

Harbormaster completed remote builds in B37614: Diff 85220.Mar 5 2021, 4:38 PM
dim accepted this revision.Mar 5 2021, 8:44 PM

Yes, I like this. It's always annoyed me that the failing values weren't printed, and that a lot of code was repeated.

lib/msun/tests/logarithm_test.c
210

Hm why is this one suddenly formatted differently? It seems to be the same number though with a lot more precision?

This revision is now accepted and ready to land.Mar 5 2021, 8:44 PM
arichardson added inline comments.Mar 12 2021, 5:38 PM
lib/msun/tests/logarithm_test.c
210

Unintended change, I just had a look whether pasting the value from a high-precision calculator would change the output. Will drop before comitting.

Closed by commit rGb424e0038a00: Improve test messages for msun tests (authored by arichardson). · Explain WhyMar 22 2021, 12:01 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGb424e0038a00: Improve test messages for msun tests.
arichardson added a commit: rGbc04f427f54f: Improve test messages for msun tests.Apr 22 2021, 11:09 AM

Revision Contents
Changeset List

PathSize
lib/
msun/
tests/
9 lines
12 lines
7 lines
11 lines
2 lines
2 lines
2 lines
2 lines
7 lines
4 lines
6 lines
18 lines
36 lines
2 lines
86 lines
2 lines

Diff 85220

View Options

lib/msun/tests/cexp_test.c

Loading...
View Options

lib/msun/tests/conj_test.c

Loading...
View Options

lib/msun/tests/csqrt_test.c

Loading...
View Options

lib/msun/tests/ctrig_test.c

Loading...
View Options

lib/msun/tests/exponential_test.c

Loading...
View Options

lib/msun/tests/fenv_test.c

Loading...
View Options

lib/msun/tests/fma_test.c

Loading...
View Options

lib/msun/tests/fmaxmin_test.c

Loading...
View Options

lib/msun/tests/invctrig_test.c

Loading...
View Options

lib/msun/tests/invtrig_test.c

Loading...
View Options

lib/msun/tests/logarithm_test.c

Loading...
View Options

lib/msun/tests/lrint_test.c

Loading...
View Options

lib/msun/tests/nearbyint_test.c

Loading...
View Options

lib/msun/tests/next_test.c

Loading...
View Options

lib/msun/tests/test-utils.h

Loading...
View Options

lib/msun/tests/trig_test.c

Loading...