Page MenuHomeFreeBSD

Improve test messages for msun tests
ClosedPublic

Authored by arichardson on Mar 5 2021, 4:34 PM.

Details

Summary

Also print the mismatched values when numbers compare not equal.

Depends on D28798

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Remove unrelated makefile change

Yes, I like this. It's always annoyed me that the failing values weren't printed, and that a lot of code was repeated.

lib/msun/tests/logarithm_test.c
210

Hm why is this one suddenly formatted differently? It seems to be the same number though with a lot more precision?

This revision is now accepted and ready to land.Mar 5 2021, 8:44 PM
lib/msun/tests/logarithm_test.c
210

Unintended change, I just had a look whether pasting the value from a high-precision calculator would change the output. Will drop before comitting.

This revision was automatically updated to reflect the committed changes.