Page MenuHomeFreeBSD
Differential D29091

Improve test messages for msun tests
ClosedPublic
Actions

Authored by arichardson on Mar 5 2021, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 14 2024, 11:24 PM
Unknown Object (File)
Oct 2 2024, 1:26 AM
Unknown Object (File)
Sep 22 2024, 9:53 AM
Unknown Object (File)
Sep 21 2024, 6:03 PM
Unknown Object (File)
Sep 19 2024, 4:13 PM
Unknown Object (File)
Sep 19 2024, 4:12 PM
Unknown Object (File)
Sep 19 2024, 4:12 PM
Unknown Object (File)
Sep 19 2024, 4:12 PM
View All 91 Files
Subscribers
imp

Details

Reviewers
ngie
dim
lwhsu
Commits
rGbc04f427f54f: Improve test messages for msun tests
rGb424e0038a00: Improve test messages for msun tests
Summary

Also print the mismatched values when numbers compare not equal.

Depends on D28798

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 5 2021, 4:34 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2021, 4:34 PM
arichardson requested review of this revision.Mar 5 2021, 4:34 PM
Harbormaster completed remote builds in B37613: Diff 85216.Mar 5 2021, 4:34 PM
arichardson added a child revision: D29076: Fix lib/msun/tests/csqrt_test on platforms with 128-bit long double.Mar 5 2021, 4:36 PM
arichardson mentioned this in D29076: Fix lib/msun/tests/csqrt_test on platforms with 128-bit long double.
arichardson updated this revision to Diff 85220.Mar 5 2021, 4:38 PM

Remove unrelated makefile change

Harbormaster completed remote builds in B37614: Diff 85220.Mar 5 2021, 4:38 PM
dim accepted this revision.Mar 5 2021, 8:44 PM

Yes, I like this. It's always annoyed me that the failing values weren't printed, and that a lot of code was repeated.

lib/msun/tests/logarithm_test.c
210

Hm why is this one suddenly formatted differently? It seems to be the same number though with a lot more precision?

This revision is now accepted and ready to land.Mar 5 2021, 8:44 PM
arichardson added inline comments.Mar 12 2021, 5:38 PM
lib/msun/tests/logarithm_test.c
210

Unintended change, I just had a look whether pasting the value from a high-precision calculator would change the output. Will drop before comitting.

Closed by commit rGb424e0038a00: Improve test messages for msun tests (authored by arichardson). · Explain WhyMar 22 2021, 12:01 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGb424e0038a00: Improve test messages for msun tests.
arichardson added a commit: rGbc04f427f54f: Improve test messages for msun tests.Apr 22 2021, 11:09 AM

Revision Contents
Changeset List

PathSize
lib/
msun/
tests/
9 lines
12 lines
7 lines
11 lines
2 lines
2 lines
2 lines
2 lines
7 lines
4 lines
6 lines
18 lines
36 lines
2 lines
86 lines
2 lines

Diff 86138

View Options

lib/msun/tests/cexp_test.c

Loading...
View Options

lib/msun/tests/conj_test.c

Loading...
View Options

lib/msun/tests/csqrt_test.c

Loading...
View Options

lib/msun/tests/ctrig_test.c

Loading...
View Options

lib/msun/tests/exponential_test.c

Loading...
View Options

lib/msun/tests/fenv_test.c

Loading...
View Options

lib/msun/tests/fma_test.c

Loading...
View Options

lib/msun/tests/fmaxmin_test.c

Loading...
View Options

lib/msun/tests/invctrig_test.c

Loading...
View Options

lib/msun/tests/invtrig_test.c

Loading...
View Options

lib/msun/tests/logarithm_test.c

Loading...
View Options

lib/msun/tests/lrint_test.c

Loading...
View Options

lib/msun/tests/nearbyint_test.c

Loading...
View Options

lib/msun/tests/next_test.c

Loading...
View Options

lib/msun/tests/test-utils.h

Loading...
View Options

lib/msun/tests/trig_test.c

Loading...