net: remove legacy in_addmulti()
ClosedPublic
Actions

Authored by kp on Feb 24 2021, 5:16 PM.

Details

Reviewers

bz
melifaro

Group Reviewers

network

Commits

rGf3245be3499b: net: remove legacy in_addmulti()

Summary

Despite the comment to the contrary neither pf nor carp use
in_addmulti(). Nothing does, so get rid of it.

Carp stopped using it in 08b68b0e4c6b132127919cfbaf7275c727ca7843
(2011). It's unclear when pf stopped using it, but before
d6d3f01e0a3395c1fae34a3c4be7b051cb2d7581 (2012).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37350
Build 34239: arc lint + arc unit

Event Timeline

kp created this revision.Feb 24 2021, 5:16 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptFeb 24 2021, 5:16 PM

Harbormaster completed remote builds in B37350: Diff 84618.Feb 24 2021, 5:16 PM

kp requested review of this revision.Feb 24 2021, 5:16 PM

Looks ok to me; Do we assume that no kmods from port would still use this?

This revision is now accepted and ready to land.Feb 24 2021, 5:30 PM

That would be my assumption.

It's hard to know for sure no one uses this. The best way to figure that out is to remove it and wait for the shouting to start.
I'd say we should remove it in main (i.e. 14), but not MFC the removal. That should give us plenty of time to notice if this does break something.

+1 for removing and not MFCin.

Closed by commit rGf3245be3499b: net: remove legacy in_addmulti() (authored by kp). · Explain WhyFeb 25 2021, 12:32 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf3245be3499b: net: remove legacy in_addmulti().