m_uiotombuf_nomap(): Stop clearing PG_ZERO
ClosedPublic
Actions

Authored by markj on Feb 19 2021, 8:20 PM.

Details

Reviewers

gallatin
jhb

Commits

rG1eee54cbf040: m_uiotombuf_nomap(): Stop clearing PG_ZERO in newly allocated pages
rG608c44f96e88: m_uiotombuf_nomap(): Stop clearing PG_ZERO in newly allocated pages

Summary

It should not be necessary. vm_page_free() handles this for us. Also
ensure that M_ZERO is not specified, since that would be translated to
vm_page_alloc(VM_ALLOC_ZERO), and with a WIP patch applied that will
cause the pages to be zeroed needlessly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 19 2021, 8:20 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2021, 8:20 PM

markj requested review of this revision.Feb 19 2021, 8:20 PM

Harbormaster completed remote builds in B37205: Diff 84296.Feb 19 2021, 8:20 PM

markj added a parent revision: D28807: vm fault: Adapt to new VM_ALLOC_ZERO semantics.Feb 19 2021, 8:20 PM

markj added reviewers: gallatin, jhb.Feb 19 2021, 8:27 PM

gallatin accepted this revision.Feb 19 2021, 10:04 PM

This revision is now accepted and ready to land.Feb 19 2021, 10:04 PM

jhb accepted this revision.Feb 19 2021, 10:32 PM

Closed by commit rG608c44f96e88: m_uiotombuf_nomap(): Stop clearing PG_ZERO in newly allocated pages (authored by markj). · Explain WhyFeb 22 2021, 3:06 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG608c44f96e88: m_uiotombuf_nomap(): Stop clearing PG_ZERO in newly allocated pages.

markj added a commit: rG1eee54cbf040: m_uiotombuf_nomap(): Stop clearing PG_ZERO in newly allocated pages.Mar 1 2021, 12:33 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_mbuf.c

2 lines

Diff 84461

View Options

m_uiotombuf_nomap(): Stop clearing PG_ZEROClosedPublicActions