Page MenuHomeFreeBSD

x86/iommu: Update following VM_ALLOC_ZERO semantic change
AcceptedPublic

Authored by markj on Fri, Feb 19, 8:19 PM.

Details

Reviewers
kib
Summary

This function is a bit special because it may return a resident page
without zeroing it, so I added an assertion and made this diff separate.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37203
Build 34092: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Fri, Feb 19, 9:15 PM
alc added inline comments.
sys/x86/iommu/intel_utils.c
274–275

Why not now move the locking outside the loop since we're no longer trying to perform the zeroing without the object lock being held? There would be two fewer lines of code, plus one more if unnecessary braces around the first unlock were eliminated.