Page MenuHomeFreeBSD
Differential D28849

loader: use display pixel density for font autoselection
ClosedPublic
Actions

Authored by tsoome on Feb 22 2021, 9:14 AM.
Tags
None
Referenced Files
F112057325: D28849.id84441.diff
Wed, Mar 12, 5:23 AM
F112054215: D28849.id84437.diff
Wed, Mar 12, 4:15 AM
F112013743: D28849.diff
Tue, Mar 11, 2:09 PM
Unknown Object (File)
Tue, Feb 25, 11:15 AM
Unknown Object (File)
Sun, Feb 23, 10:21 PM
Unknown Object (File)
Sun, Feb 23, 5:14 PM
Unknown Object (File)
Fri, Feb 21, 5:52 AM
Unknown Object (File)
Tue, Feb 18, 7:33 PM
View All Files
Subscribers
bcran
imp
rhurlin
royger

Details

Reviewers
None
Commits
rGbecaac3972f1: loader: use display pixel density for font autoselection
Summary

Calculate font size from 16 density independent pixels (dp) by using:
size = 16 * ppi/160 * display_factor

We are specifying font size 16dp, and assuming 1dp = 160ppi.
Also apply scaling factor 2 (display_factor).

Test Plan

test with different systems and resolutions

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37258
Build 34147: arc lint + arc unit

Event Timeline

tsoome created this revision.Feb 22 2021, 9:14 AM
Herald added subscribers: bcran, imp. · View Herald TranscriptFeb 22 2021, 9:14 AM
tsoome requested review of this revision.Feb 22 2021, 9:14 AM
Harbormaster completed remote builds in B37258: Diff 84437.Feb 22 2021, 9:15 AM
tsoome updated this revision to Diff 84441.Feb 22 2021, 9:42 AM

use gop_handle, not gop protocol

Harbormaster completed remote builds in B37260: Diff 84441.Feb 22 2021, 9:42 AM
tsoome updated this revision to Diff 84522.Feb 23 2021, 10:46 AM

make it actually to work...

Harbormaster completed remote builds in B37297: Diff 84522.Feb 23 2021, 10:46 AM
rhurlin added a subscriber: rhurlin.Feb 23 2021, 1:00 PM
royger added a subscriber: royger.Feb 23 2021, 2:43 PM

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

royger added a comment.Feb 23 2021, 3:45 PM

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

stand/efi/loader/framebuffer.c
506

size = MAX(sizeof(*edid_infop), edid->SizeOfEdid);

tsoome marked an inline comment as done.Feb 24 2021, 10:07 AM
tsoome updated this revision to Diff 84599.Feb 24 2021, 10:10 AM

use MAX().

Harbormaster completed remote builds in B37337: Diff 84599.Feb 24 2021, 10:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2021, 9:28 AM
Closed by commit rGbecaac3972f1: loader: use display pixel density for font autoselection (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rGbecaac3972f1: loader: use display pixel density for font autoselection.

Revision Contents
Changeset List

PathSize
stand/
common/
2 lines
108 lines
efi/
libefi/
23 lines
loader/
83 lines
i386/
libi386/
25 lines

Diff 84437

View Options

stand/common/gfx_fb.h

Loading...
View Options

stand/common/gfx_fb.c

Loading...
View Options

stand/efi/libefi/efi_console.c

Loading...
View Options

stand/efi/loader/framebuffer.c

Loading...
View Options

stand/i386/libi386/vbe.c

Loading...