Page MenuHomeFreeBSD

loader: use display pixel density for font autoselection
ClosedPublic

Authored by tsoome on Feb 22 2021, 9:14 AM.
Tags
None
Referenced Files
F133643694: D28849.diff
Mon, Oct 27, 5:53 AM
Unknown Object (File)
Fri, Oct 24, 5:50 PM
Unknown Object (File)
Mon, Oct 20, 6:21 AM
Unknown Object (File)
Sat, Oct 18, 6:51 PM
Unknown Object (File)
Mon, Oct 13, 10:24 AM
Unknown Object (File)
Sun, Oct 5, 3:50 AM
Unknown Object (File)
Sep 22 2025, 3:37 PM
Unknown Object (File)
Sep 22 2025, 12:52 AM

Details

Summary

Calculate font size from 16 density independent pixels (dp) by using:
size = 16 * ppi/160 * display_factor

We are specifying font size 16dp, and assuming 1dp = 160ppi.
Also apply scaling factor 2 (display_factor).

Test Plan

test with different systems and resolutions

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37297
Build 34186: arc lint + arc unit

Event Timeline

use gop_handle, not gop protocol

make it actually to work...

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

stand/efi/loader/framebuffer.c
506

size = MAX(sizeof(*edid_infop), edid->SizeOfEdid);

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2021, 9:28 AM
This revision was automatically updated to reflect the committed changes.