Page MenuHomeFreeBSD

loader: use display pixel density for font autoselection
ClosedPublic

Authored by tsoome on Feb 22 2021, 9:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2024, 7:16 PM
Unknown Object (File)
Dec 20 2023, 7:27 AM
Unknown Object (File)
Dec 12 2023, 1:17 AM
Unknown Object (File)
Nov 24 2023, 12:40 PM
Unknown Object (File)
Nov 20 2023, 7:13 AM
Unknown Object (File)
Nov 20 2023, 7:13 AM
Unknown Object (File)
Nov 20 2023, 7:13 AM
Unknown Object (File)
Nov 10 2023, 7:03 PM

Details

Summary

Calculate font size from 16 density independent pixels (dp) by using:
size = 16 * ppi/160 * display_factor

We are specifying font size 16dp, and assuming 1dp = 160ppi.
Also apply scaling factor 2 (display_factor).

Test Plan

test with different systems and resolutions

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37260
Build 34149: arc lint + arc unit

Event Timeline

use gop_handle, not gop protocol

make it actually to work...

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

stand/efi/loader/framebuffer.c
505

size = MAX(sizeof(*edid_infop), edid->SizeOfEdid);

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2021, 9:28 AM
This revision was automatically updated to reflect the committed changes.