Page MenuHomeFreeBSD

loader: use display pixel density for font autoselection
ClosedPublic

Authored by tsoome on Feb 22 2021, 9:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 8:24 AM
Unknown Object (File)
Fri, Apr 26, 2:41 AM
Unknown Object (File)
Fri, Apr 26, 2:41 AM
Unknown Object (File)
Fri, Apr 26, 2:41 AM
Unknown Object (File)
Fri, Apr 26, 2:40 AM
Unknown Object (File)
Fri, Apr 26, 2:29 AM
Unknown Object (File)
Fri, Apr 26, 2:29 AM
Unknown Object (File)
Thu, Apr 25, 8:43 PM

Details

Summary

Calculate font size from 16 density independent pixels (dp) by using:
size = 16 * ppi/160 * display_factor

We are specifying font size 16dp, and assuming 1dp = 160ppi.
Also apply scaling factor 2 (display_factor).

Test Plan

test with different systems and resolutions

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

use gop_handle, not gop protocol

make it actually to work...

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

stand/efi/loader/framebuffer.c
506

size = MAX(sizeof(*edid_infop), edid->SizeOfEdid);

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2021, 9:28 AM
This revision was automatically updated to reflect the committed changes.