Differential D28329

Adjust line length in tcp_prr_partialack
ClosedPublic
Actions

Authored by rscheff on Jan 25 2021, 11:21 AM.

Tags

None

Referenced Files

	F110639698: D28329.id82914.diff
	Fri, Feb 21, 7:37 AM

	Unknown Object (File)
	Thu, Feb 13, 10:23 AM

	Unknown Object (File)
	Thu, Feb 13, 10:20 AM

	Unknown Object (File)
	Thu, Feb 13, 9:56 AM

	Unknown Object (File)
	Thu, Feb 13, 7:10 AM

	Unknown Object (File)
	Sat, Feb 8, 1:11 AM

	Unknown Object (File)
	Mon, Jan 27, 8:13 PM

	Unknown Object (File)
	Sun, Jan 26, 7:41 PM

Subscribers

Details

Reviewers

tuexen
rrs
jtl
mm
kbowling

Group Reviewers

Commits

rGe6341fd7220e: Adjust line length in tcp_prr_partialack
rG84761f3df508: Adjust line length in tcp_prr_partialack

Summary

Wrap lines before column 80 in new prr code checked in recently.

No functional changes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36463
Build 33352: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 25 2021, 11:21 AM

Herald added a reviewer: transport. · View Herald TranscriptJan 25 2021, 11:21 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jan 25 2021, 11:21 AM

Harbormaster completed remote builds in B36463: Diff 82842.Jan 25 2021, 11:22 AM

tuexen added inline comments.Jan 25 2021, 12:23 PM

sys/netinet/tcp_input.c
3953	Why not have the / operator at the end of the line before instead at the beginning of this line. That pattern is used in the lines below for the - operator.

address comment

Harbormaster completed remote builds in B36464: Diff 82844.Jan 25 2021, 12:31 PM

LGTM.

tuexen accepted this revision.Jan 25 2021, 1:25 PM

This revision is now accepted and ready to land.Jan 25 2021, 1:25 PM

Closed by commit rG84761f3df508: Adjust line length in tcp_prr_partialack (authored by rscheff). · Explain WhyJan 26 2021, 3:02 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG84761f3df508: Adjust line length in tcp_prr_partialack.

rscheff added a commit: rGe6341fd7220e: Adjust line length in tcp_prr_partialack.Jan 29 2021, 10:56 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

13 lines

Diff 82842

sys/netinet/tcp_input.c

Loading...