Differential D28225

Set VM_KMEM_SIZE_SCALE to 1 on riscv and arm64
ClosedPublic
Actions

Authored by markj on Jan 18 2021, 6:47 PM.

Tags

None

Referenced Files

	F150266451: D28225.diff
	Mon, Mar 30, 6:23 PM

	Unknown Object (File)
	Mon, Mar 30, 1:50 AM

	Unknown Object (File)
	Mon, Mar 23, 6:26 PM

	Unknown Object (File)
	Tue, Mar 17, 4:32 AM

	Unknown Object (File)
	Mon, Mar 16, 6:29 PM

	Unknown Object (File)
	Sun, Mar 15, 2:04 AM

	Unknown Object (File)
	Tue, Mar 10, 4:34 PM

	Unknown Object (File)
	Mon, Mar 2, 7:48 PM

Subscribers

Details

Reviewers

manu
kib
alc
kp

Group Reviewers

riscv
arm64

Commits

rG3e3eb5f45f33: arm64, riscv: Set VM_KMEM_SIZE_SCALE to 1

Summary

This parameter limits the amount of memory that can be allocated to UMA.
On systems with a direct map and ample KVA, however, I can't see a
reason for VM_KMEM_SIZE_SCALE to be larger than 1. I believe it was
copied from 32-bit ARM to arm64 and from there to riscv.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36327
Build 33216: arc lint + arc unit

Event Timeline

markj created this revision.Jan 18 2021, 6:47 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 18 2021, 6:47 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

markj requested review of this revision.Jan 18 2021, 6:47 PM

Harbormaster completed remote builds in B36323: Diff 82494.Jan 18 2021, 6:47 PM

markj added reviewers: kib, alc, riscv, arm64.Jan 18 2021, 6:48 PM

kib accepted this revision.Jan 18 2021, 7:02 PM

This revision is now accepted and ready to land.Jan 18 2021, 7:02 PM

kp accepted this revision as: kp.Jan 18 2021, 10:10 PM

Similarly, there is no reason to define VM_KMEM_SIZE_MIN.

Remove VM_KMEM_SIZE_MIN as well.

This revision now requires review to proceed.Jan 19 2021, 12:35 AM

Harbormaster completed remote builds in B36327: Diff 82513.Jan 19 2021, 12:35 AM

alc accepted this revision.Jan 19 2021, 6:54 AM

This revision is now accepted and ready to land.Jan 19 2021, 6:54 AM

kib accepted this revision.Jan 19 2021, 8:18 AM

Closed by commit rG3e3eb5f45f33: arm64, riscv: Set VM_KMEM_SIZE_SCALE to 1 (authored by markj). · Explain WhyJan 20 2021, 1:38 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3e3eb5f45f33: arm64, riscv: Set VM_KMEM_SIZE_SCALE to 1.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

9 lines

riscv/

include/

9 lines

Diff 82513

sys/arm64/include/vmparam.h

Loading...

sys/riscv/include/vmparam.h

Loading...