Details

Reviewers

julian
glebius
mav
kp

Group Reviewers

network

Commits

rG90d158c0cf25: netgraph/ng_tag: permit variable length data
rG305b3ca5f40c: netgraph/ng_tag: permit variable length data
rG7c7c231c1424: netgraph/ng_tag: permit variable length data

Summary

ng_tag can operate on arbitrary data of mbuf_tags.
This should work for any data sets.

ngctl
+ mkpeer . tag t t
+ msg t sethookin { thisHook="t" tag_len=4 tag_data=[1] }

works. But the following does not:

+ msg t sethookin { thisHook="t" tag_len=1 tag_data=[1] }
ngctl: send msg: Invalid argument

Especially in the case of checking for mbuf_tag values, the length
of checked data is important.

The reason behind this behavior is, that the record size
is padded to the next multiple of the alignment. Therefore
it's sufficient to check for large enough data received.

PR: 241462

Test Plan

+ mkpeer . tag t t
+ msg t sethookin { thisHook="t" tag_len=4 tag_data=[1] }
+ msg t sethookin { thisHook="t" tag_len=1 tag_data=[1] }
+ msg t gethookin "t"
Rec'd response "gethookin" (2) from "[72]:":
Args:   { thisHook="t" tag_len=1 tag_data=[ 0x1 ] }

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

donner created this revision.Oct 24 2019, 11:27 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptOct 24 2019, 11:27 AM

Harbormaster completed remote builds in B27196: Diff 63631.Oct 24 2019, 11:27 AM

donner added a reviewer: network.Oct 24 2019, 11:28 AM

donner edited the summary of this revision. (Show Details)Oct 24 2019, 11:34 AM

donner added inline comments.

sys/netgraph/ng_tag.c
366–367	Reformatted to more readability and conformance to style(9)

donner edited the summary of this revision. (Show Details)Oct 24 2019, 2:03 PM

donner edited the summary of this revision. (Show Details)

I think you need to add people with good knowledge of the netgraph to the reviewers: JulianElischer, Gleb Smirnoff and Alexander Motin. Because apparently not all are subscribed to the network mailing list.