In D27959#624564, @emaste wrote:

LGTM even though we're probably close to the point where it makes sense to have a loop with a list of extensions to ignore.

alternatively, we could say: if it has >= 2 '.', skip it

alternatively, we could say: if it has >= 2 '.', skip it

Yes I think that's reasonable if you're up for updating this review with that change (or I'll take this one as is).

In D27959#624597, @emaste wrote:

alternatively, we could say: if it has >= 2 '.', skip it

Yes I think that's reasonable if you're up for updating this review with that change (or I'll take this one as is).

naïvely, i'd implement this like,

char *first_dot  = strchr(p->fts_name, '.');
char *last_dot = strchrt(p->fts_name, '.');
if (first_dot != NULL && last_dot != NULL && first_dot != last_dot)
        continue;

assuming that .symbols and .debug files usually look like: foo.ko.debug and bar.ko.symbols like with .pkgsave files.

same functionality, written in C instead of python style C. thanks to RhodiumToad:

char *dot = strchr(p->fts_name, '.');
if (dot && strchr(dot+1, '.') != NULL)
        continue;

i don't suppose dot+1 will push us *past* \0, so we don't need to check if we still have enough string left

address @kevans' feedback, by moving local_rc *.pkgsave skipping into the skipping of scratch files, since that issues a warning.

I'm going to update this review with an edit to the man page, and then we can revive it.

You didn't ask for manpages approval. Is that deliberate?

In D27959#880578, @pauamma wrote:

You didn't ask for manpages approval. Is that deliberate?

I thought requiring manpages is automatic as soon as you add/modify a man page

Please remember to bump .Dd :)

I think this is now missing the .c code changes.

one day, i will use arc and it will not mess up my review.
one day, really soon.

It's fine this way...
Or we could also just whine less with weird files we encounter, though that's likely riskier than this tactic.