add .pkgsave to list of skipped files, by skipping all files that
contain two '.'
Motivation: This should help people transitioning from
traditional setups to pkgbase experience a lot less friction.
Differential D27959
kldxref: skip .pkgsave files me_igalic.co on Jan 4 2021, 9:29 PM. Authored by
Details add .pkgsave to list of skipped files, by skipping all files that Motivation: This should help people transitioning from update your system to pkgbase (using, for instance https://alpha.pkgbase.live/ ;) service kldxref onerestart apply this patch
Diff Detail
Event TimelineComment Actions LGTM even though we're probably close to the point where it makes sense to have a loop with a list of extensions to ignore. Comment Actions
Yes I think that's reasonable if you're up for updating this review with that change (or I'll take this one as is). Comment Actions naïvely, i'd implement this like, char *first_dot = strchr(p->fts_name, '.'); char *last_dot = strchrt(p->fts_name, '.'); if (first_dot != NULL && last_dot != NULL && first_dot != last_dot) continue; assuming that .symbols and .debug files usually look like: foo.ko.debug and bar.ko.symbols like with .pkgsave files. Comment Actions same functionality, written in C instead of python style C. thanks to RhodiumToad: char *dot = strchr(p->fts_name, '.'); if (dot && strchr(dot+1, '.') != NULL) continue; i don't suppose dot+1 will push us *past* \0, so we don't need to check if we still have enough string left Comment Actions address @kevans' feedback, by moving local_rc *.pkgsave skipping into the skipping of scratch files, since that issues a warning. |