Sponsored by: The FreeBSD Foundation
Details
Details
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 35643 Build 32534: arc lint + arc unit
Event Timeline
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2948–2949 | I wonder if it would be clear to say no advantage to lower compression levels to avoid the double negative. Or something like "but read many times, Zstd allows the use of high compression levels without a performance penalty." | |
Comment Actions
I can't vouch for the technical accuracy of this, not having the required knowledge of ZFS and OpenZFS, but other than that and a few nits, this looks fine.
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2946 | After the initial introduction of both "Zstandard" and its acronym "Zstd", I'd use one consistently, not a mix of both. | |
| 2956 | Clarification: here and in the following paragraph, is it ZFS or OpenZFS? | |
| 2981 | That paragraph doesn't state how to change the compression from the default. | |
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2946 | Done | |
| 2956 | They are fairly synonymous, I think we'll have to do an entire pass over the handbook at some point | |
| 2981 |
That is covered in the properties chapter, not sure if it makes sense to repeat it here. It might. | |
Comment Actions
Cool, a nice addition to the handbook covering the newer ZFS features. Thanks for the writeup!
Comment Actions
Do I remember wrong, or does Zstd also offer the option to adaptively compress at as high a level as possible while maintaining bandwidth, or is that only for zfs send|receive? If so, should that also be mentioned?
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2940–2941 | Should this be "is the default as of FreeBSD 13-CURRENT and will be in 13.0-RELEASE"? | |
| 2958 | s/cache/memory/ | |
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2958 |
Or better yet: | |
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2949 | mmm, reading it again, maybe we should mention without a "read" performance penalty? | |
Comment Actions
That is the command line zstd tool, ZFS doesn't have anything like this (yet)
| en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2949 | agreed | |
Comment Actions
I think you've addressed all the feedback and had approvals from everyone attached ;)