openzfs: fix gcc in-kernel builds
ClosedPublic
Actions

Authored by rlibby on Dec 20 2020, 8:31 AM.

Details

Reviewers

markj
mmacy

Commits

rG1ee339e257b3: openzfs: fix gcc in-kernel builds

Summary

Fix gcc builds of in-kernel modules using CDDL_CFLAGS (e.g. options
ZFS).

Remove nonexistent include dirs for -Wmissing-include-dirs
Suppress -Wnested-externs, a useless warning
Sort and uniq warning flags while here

Test Plan

With options ZFS and dependencies added to GENERIC:

make buildkernel

env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make buildkernel

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35547
Build 32447: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 20 2020, 8:31 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2020, 8:31 AM

rlibby requested review of this revision.Dec 20 2020, 8:31 AM

Harbormaster completed remote builds in B35547: Diff 80966.Dec 20 2020, 8:31 AM

markj accepted this revision.Dec 21 2020, 1:59 PM

This revision is now accepted and ready to land.Dec 21 2020, 1:59 PM

markj added inline comments.Dec 21 2020, 2:00 PM

sys/conf/kern.pre.mk
230	BTW, @brewery discovered last week that the use of -Wno-uninitialized is covering up bugs in dtrace. I think he is looking at removing this option.

rlibby added inline comments.Dec 23 2020, 8:21 AM

sys/conf/kern.pre.mk
230	Glad to hear it. I'll make sure to try the gcc build again after that goes in.

Closed by commit rG1ee339e257b3: openzfs: fix gcc in-kernel builds (authored by rlibby). · Explain WhyDec 24 2020, 8:37 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG1ee339e257b3: openzfs: fix gcc in-kernel builds.

Revision Contents
Changeset List

Path

Size

sys/

conf/

kern.pre.mk

22 lines

Diff 80966

View Options

openzfs: fix gcc in-kernel buildsClosedPublicActions