Details

Reviewers

None

Group Reviewers

Summary

RabbitMQ has moved to a much tighter cycle of support, now that the
Erlang OTP team has also made clear their support policy is penultimate
+ current release only.

Now we have OTP24 in ports let's move to that because JIT.

PATH leakage fixed
linuxisms for /var/db/rabbitmq fixed
rc.d works
man pages use hier(7) paths

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 35289
Build 32222: arc lint + arc unit

Event Timeline

dch created this revision.Dec 10 2020, 9:36 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 10 2020, 9:36 AM

dch requested review of this revision.Dec 10 2020, 9:36 AM

Harbormaster completed remote builds in B35288: Diff 80502.Dec 10 2020, 9:36 AM

PATH needs to have erlang23/bin prepended in all the usual places
HOMEDIR isn't being set properly with the amended scripts

o tiny cuttlefish, we miss you
fix more /var/lib/rabbitmq linuxisms

Harbormaster completed remote builds in B35289: Diff 80507.Dec 10 2020, 10:15 AM

fix ERL_DIR diff

Harbormaster completed remote builds in B35290: Diff 80508.Dec 10 2020, 10:32 AM

more ERL_DIR path injection

Harbormaster completed remote builds in B35291: Diff 80509.Dec 10 2020, 10:46 AM

drop cuttlefish binary it has been superceded

Harbormaster completed remote builds in B35292: Diff 80510.Dec 10 2020, 11:29 AM

damn you cuttlefish hiding in so many crevices

Harbormaster completed remote builds in B35293: Diff 80511.Dec 10 2020, 11:54 AM

addressed HOMEDIR issue via RABBITMQ_MNESIA_BASE

Harbormaster completed remote builds in B35295: Diff 80514.Dec 10 2020, 1:08 PM

Hi!

After seeing the significant amount of patching being done to tune the defaults to FreeBSD file hierarchy, I believe it would be way easier to install a ${LOCALBASE}/etc/rabbitmq/rabbitmq-env.conf file instead. The only patch required would be setting SYS_PREFIX in rabbitmq-defaults.

Then, the content of rabbitmq-env.conf would be:

# rabbitmq user's home.
HOME=/var/db/rabbitmq

# Adjust $PATH to default to Erlang 23.
PATH=${LOCALBASE}/lib/erlang23/bin:$PATH

# Data & log files locations.
RABBITMQ_MNESIA_BASE=${HOME}/mnesia
RABBITMQ_LOG_BASE=/var/log/rabbitmq

What do you think?

In D27532#616893, @dumbbell wrote:
Hi!

After seeing the significant amount of patching being done to tune the defaults to FreeBSD file hierarchy, I believe it would be way easier to install a ${LOCALBASE}/etc/rabbitmq/rabbitmq-env.conf file instead. The only patch required would be setting SYS_PREFIX in rabbitmq-defaults.

Then, the content of rabbitmq-env.conf would be:
# rabbitmq user's home.
HOME=/var/db/rabbitmq

# Adjust $PATH to default to Erlang 23.
PATH=${LOCALBASE}/lib/erlang23/bin:$PATH

# Data & log files locations.
RABBITMQ_MNESIA_BASE=${HOME}/mnesia
RABBITMQ_LOG_BASE=/var/log/rabbitmq
What do you think?

this is 10x better, yes thanks! how can we handle the very common situation
of a rabbitmq-env.conf already existing, that wouldn't have these settings?

port builds, using OTP23 as baseline but runtime PATH for /var/db/rabbitmq
still defaults incorrectly to /var/lib/rabbitmq. further debugging needed.

Harbormaster completed remote builds in B40089: Diff 91343.Jun 25 2021, 12:14 PM

dch retitled this revision from net/rabbitmq: update to 3.8.9 and latest OTP23 to net/rabbitmq: update to 3.8.18 and OTP24 with jit support.Jun 26 2021, 3:19 PM

dch edited the summary of this revision. (Show Details)

dch edited the test plan for this revision. (Show Details)

dch added a reviewer: Erlang.

dch added a project: Erlang.

OTP24

Harbormaster completed remote builds in B40138: Diff 91429.Jun 28 2021, 9:35 AM

remove PATH tweaks in favour of SYS_PREFIX introduced in 3.8.4

Harbormaster completed remote builds in B40139: Diff 91430.Jun 28 2021, 9:40 AM

fix path handling
fix directory location

Harbormaster completed remote builds in B40141: Diff 91434.Jun 28 2021, 10:58 AM

dch edited the summary of this revision. (Show Details)Jun 28 2021, 11:14 AM

resolve rc.d script issues in start|stop|status