Page MenuHomeFreeBSD
Differential D26839

[axgbe] fix compiler warnings when compiling using gcc-6.4
ClosedPublic
Actions

Authored by adrian on Oct 18 2020, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 2 2024, 1:32 AM
Unknown Object (File)
May 1 2024, 6:24 AM
Unknown Object (File)
Apr 30 2024, 8:10 AM
Unknown Object (File)
Apr 29 2024, 3:54 PM
Unknown Object (File)
Apr 20 2024, 10:28 AM
Unknown Object (File)
Apr 20 2024, 10:28 AM
Unknown Object (File)
Apr 18 2024, 1:36 AM
Unknown Object (File)
Apr 18 2024, 1:19 AM
View All 36 Files
Subscribers
emaste
imp
rajesh1.kumar_amd.com
rpokala

Details

Reviewers
kevans
andrew
rajesh1.kumar_amd.com
manu
rpokala
Group Reviewers
network
Commits
rS368305: [axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue
Summary

This fixes some compiler warnings:

  • uninitialised variable use
  • Using XGBE_ADV rather than XGBE_ADV_SET in the phy-v2 path
Test Plan
  • just compile tested; I don't have hardware to test, esp the phy-v2 path

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 18 2020, 5:35 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 18 2020, 5:35 PM
Harbormaster completed remote builds in B34240: Diff 78386.Oct 18 2020, 5:35 PM
adrian requested review of this revision.Oct 18 2020, 5:35 PM
adrian added reviewers: kevans, andrew.Oct 18 2020, 5:35 PM
kevans added a reviewer: rajesh1.kumar_amd.com.Oct 18 2020, 5:37 PM
kevans added a subscriber: rajesh1.kumar_amd.com.

Adding submitter, @rajesh1.kumar_amd.com -- looks like Adrian already worked up a patch here.

adrian added reviewers: manu, network.Oct 18 2020, 6:21 PM
adrian mentioned this in D25793: 10Gigabit Ethernet driver for AMD SoC.
rajesh1.kumar_amd.com added a comment.Oct 18 2020, 6:54 PM

Thanks @adrian for taking on this. From a compilation perspective, Looks good. I don't have any more specific comments.

adrian added a comment.Oct 18 2020, 9:34 PM

who has test hardware that can test this and report back?

emaste added a subscriber: emaste.Oct 19 2020, 8:36 PM
rpokala accepted this revision.Dec 3 2020, 3:46 AM
rpokala added a subscriber: rpokala.

I don't have the hardware to test, but the change looks fine.

  1. The zero-initialization is obviously valid
  2. It's clear in context that XGBE_SET_ADV() (which sets the flag) is what was really intended, instead of testing the flag with XGBE_ADV() and throwing away the result.
This revision is now accepted and ready to land.Dec 3 2020, 3:46 AM
Closed by commit rS368305: [axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue (authored by adrian). · Explain WhyDec 3 2020, 4:55 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS368305: [axgbe] Fix compiler warnings in gcc-6.3; perhaps fix a PHY issue.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
axgbe/
2 lines
2 lines
8 lines

Diff 80267

View Options

head/sys/dev/axgbe/xgbe-dev.c

Loading...
View Options

head/sys/dev/axgbe/xgbe-mdio.c

Loading...
View Options

head/sys/dev/axgbe/xgbe-phy-v2.c

Loading...