Page MenuHomeFreeBSD

rajesh1.kumar_amd.com (Rajesh Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 8 2019, 6:50 AM (111 w, 4 d)

Recent Activity

Wed, Feb 3

rajesh1.kumar_amd.com accepted D28465: "device axp" requires miibus.

One option maybe to split it into two rather than unified.

Wed, Feb 3, 6:52 PM
rajesh1.kumar_amd.com added a comment to D28465: "device axp" requires miibus.

Other than the comment mentioned, this patch looks good to me.

Wed, Feb 3, 6:03 PM

Jan 26 2021

rajesh1.kumar_amd.com added a comment to D21462: Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver.

But somehow it's comparing ntb_hw_amd with ntb_transport always.

I think this is an artifact of git's copy/rename detection, and if that's the case there's some environment variable or cmd line option to disable it. I'll try to take a look for it and update the code review wiki page.

Jan 26 2021, 5:42 PM
rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

It can be merged there (MFC'd) as well, after a period of a minimum of 3 days. There is no need to submit a separate patch.

Jan 26 2021, 5:33 PM
rajesh1.kumar_amd.com added a comment to D27799: Iflib changes to handle multiple netmap fragments.

Thanks @vmaffione for reviewing and accepting the changes.

Jan 26 2021, 5:30 PM

Jan 23 2021

rajesh1.kumar_amd.com added a comment to D27800: Man page for AMD 10GbE driver.

I take care of the commit and the MFC later on. Please submit a new differential with updates after the commit. It is so easier to review

Jan 23 2021, 6:20 PM
rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

@vmaffione, Sorry I just noticed that the stable/13 branch is created yesterday. So, can this patch be pushed to that branch as well? or do I need to submit the same patch separately for stable/13 branch?

Jan 23 2021, 4:48 PM
rajesh1.kumar_amd.com added a comment to D27800: Man page for AMD 10GbE driver.

@gbe, I see this manpage is still not in the main branch for FreeBSD-src. Can this be pushed to main branch and stable/13 branch?

Jan 23 2021, 4:46 PM
rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

Thanks @vmaffione for pushing it upstream.

Jan 23 2021, 4:11 PM
rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

Will the fix be provided as a firmware upgrade or how?
I could commit this change if you don't have someone else around that can do that for you.

Jan 23 2021, 10:37 AM
rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

Any more comments on this patch?

Jan 23 2021, 6:22 AM

Jan 22 2021

rajesh1.kumar_amd.com added a comment to D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.

Wouldn't it be easier to always perform the complete phy reset if this is a known hardware issue? Or maye perform it automatically after a normal reset does not work?
I'm afraid that adding an obscure sysctl (obscure for anyone except for the axgbe developers) would be of little use. Unaware users wouldn't have a clue about what to do...
just my 2 cents

Jan 22 2021, 8:08 AM
rajesh1.kumar_amd.com added a comment to D28115: Fix a NULL pointer reference in iflib.

Thanks @gallatin for pushing the patch.

Jan 22 2021, 4:26 AM

Jan 21 2021

rajesh1.kumar_amd.com added a comment to D27799: Iflib changes to handle multiple netmap fragments.

The kernel panic issue which I reported with pkt-gen here is root caused to an issue in the axgbe driver. Now that issue is fixed in the driver and I will submit the driver patches seperately.

Jan 21 2021, 9:34 AM
rajesh1.kumar_amd.com added a comment to D28115: Fix a NULL pointer reference in iflib.

@gallatin, I don't have the committer access for the git repo. Can you please help push this change upstream if there is no other comments?

Jan 21 2021, 8:49 AM
rajesh1.kumar_amd.com abandoned D28193: Workaround fix for intermittent link issue with axgbe driver.

Abandoning this revision and submitted another patch (D28266) which has this patch along with fixes for other known link issues with axgbe

Jan 21 2021, 8:46 AM
rajesh1.kumar_amd.com added reviewers for D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe: vmaffione, stephan.dewt_yahoo.co.uk, manu.
Jan 21 2021, 8:44 AM
rajesh1.kumar_amd.com requested review of D28266: Fix for direct attach cable and workaround for intermittent link issue with axgbe.
Jan 21 2021, 8:42 AM

Jan 18 2021

rajesh1.kumar_amd.com added a comment to D28193: Workaround fix for intermittent link issue with axgbe driver.

Thanks @stephan.dewt_yahoo.co.uk for testing and giving your comments.

Jan 18 2021, 9:58 AM

Jan 16 2021

rajesh1.kumar_amd.com added reviewers for D28193: Workaround fix for intermittent link issue with axgbe driver: vmaffione, stephan.dewt_yahoo.co.uk, manu.
Jan 16 2021, 5:15 PM
rajesh1.kumar_amd.com requested review of D28193: Workaround fix for intermittent link issue with axgbe driver.
Jan 16 2021, 5:12 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

Thanks @vmaffione for committing the changes.

Jan 16 2021, 4:54 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

Shall I commit this change?

Jan 16 2021, 3:20 AM

Jan 15 2021

rajesh1.kumar_amd.com added a comment to D27800: Man page for AMD 10GbE driver.

LGTM, since all previous comments are addressed.

Jan 15 2021, 1:09 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

I see "iflib" group review is blocking here. Now that this patch is only driver specific and doesn't have any change in iflib, does this patch need any other action to get it pushed upstream?

Jan 15 2021, 1:05 PM
rajesh1.kumar_amd.com added a comment to D28115: Fix a NULL pointer reference in iflib.

OK, thanks that makes sense. I was not considering a multi-frag case.

Jan 15 2021, 1:02 PM
rajesh1.kumar_amd.com updated the diff for D27797: AMD 10GbE driver changes for Netmap support.

V6 patch addressing the last comment

Jan 15 2021, 4:10 AM

Jan 14 2021

rajesh1.kumar_amd.com added inline comments to D27797: AMD 10GbE driver changes for Netmap support.
Jan 14 2021, 12:19 PM
rajesh1.kumar_amd.com updated the diff for D27797: AMD 10GbE driver changes for Netmap support.

V5 patch addressing all the previous comments.

Jan 14 2021, 12:11 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

If you tested all the valid combinations of sph_enable and netmap/non-netmap I don't have any objection in this being merged.

Jan 14 2021, 12:09 PM

Jan 13 2021

rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

If there is no other comments, can this patch be accepted upstream?

Jan 13 2021, 12:40 PM
rajesh1.kumar_amd.com updated the diff for D27797: AMD 10GbE driver changes for Netmap support.

V4 patch with a minor change to have both kenv and sysctl name to be same as
"sph_enable"

Jan 13 2021, 12:36 PM
rajesh1.kumar_amd.com added a comment to D28115: Fix a NULL pointer reference in iflib.

We faced this issue when testing the split header feature with "axgbe" driver.

Jan 13 2021, 7:20 AM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

When changing this via the sysctl interface (e.g. # sysctl dev.ax.0.sph_enabled=1), it returns with

sysctl: oid 'dev.ax.0.sph_enabled' is a read only tunable
sysctl: Tunable values are set in /boot/loader.conf
Jan 13 2021, 5:34 AM

Jan 12 2021

rajesh1.kumar_amd.com added reviewers for D28115: Fix a NULL pointer reference in iflib: vmaffione, mmacy.
Jan 12 2021, 12:41 PM
rajesh1.kumar_amd.com requested review of D28115: Fix a NULL pointer reference in iflib.
Jan 12 2021, 12:39 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

Regarding the case sph_enable = 0 and single_fl = 0, I would like to add a
new isc_flag that you can set to tell iflib that you don't want to allow
netmap on this driver. In this way you can set the flag in case sph_enable
single_fl = 0, so that users won't do mistakes.

Jan 12 2021, 12:11 PM
rajesh1.kumar_amd.com updated the diff for D27797: AMD 10GbE driver changes for Netmap support.

V3 patch with following changes

Jan 12 2021, 12:05 PM

Jan 10 2021

rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

For now, I will better remove the "single_fl" sysctl and retain just the "sph_enable" and the changes (without any iflib changes) to get netmap bridging to work. Thanks @stephan.dewt_yahoo.co.uk for those changes. So, the next patch will be a driver only patch without any need for iflib changes.

Jan 10 2021, 12:20 PM

Jan 8 2021

rajesh1.kumar_amd.com updated the diff for D27800: Man page for AMD 10GbE driver.

V3 patch addressing previous comments.

Jan 8 2021, 12:15 PM
rajesh1.kumar_amd.com added inline comments to D27800: Man page for AMD 10GbE driver.
Jan 8 2021, 12:13 PM
rajesh1.kumar_amd.com updated the diff for D27797: AMD 10GbE driver changes for Netmap support.

V2 patch addressing the previous comments

Jan 8 2021, 12:05 PM
rajesh1.kumar_amd.com added a comment to D27797: AMD 10GbE driver changes for Netmap support.

Are both netmap_test and sph_enable actually necessary? Would it make sense to have only sph_enable, and set isc_nfl = 1 when sph_enable = 0 and isc_nfl = 2 when sph_enable = 1?
If not, I think netmap_test should be called something like single_free_list

I agree, both sysctl variables now depend on each other. I will create a change and submit it for review here once I find the time.

Jan 8 2021, 11:54 AM
rajesh1.kumar_amd.com added a comment to D27799: Iflib changes to handle multiple netmap fragments.

Ok, so the axgbe netmap receive datapath panics. Does this happen with or
without D27797?
If the panic is not introduced by your changes (e.g. if it is in HEAD) you
should submit a bug to the bugzilla.

Jan 8 2021, 11:08 AM
rajesh1.kumar_amd.com abandoned D27877: Support for NS_MOREFRAG in Netmap bridge utility.

Abandoning this revision as the necessary fix is done as part of D27980.

Jan 8 2021, 9:38 AM
rajesh1.kumar_amd.com added a comment to D27877: Support for NS_MOREFRAG in Netmap bridge utility.

Done. We should therefore close this review.

Jan 8 2021, 9:37 AM

Jan 6 2021

rajesh1.kumar_amd.com added a comment to D27799: Iflib changes to handle multiple netmap fragments.

You could then try something like:

pkt-gen -i ax0 -f tx -F 3

or

pkt-gen -i ax0 -f tx -F 2 -M 100

and check that the receiver indeed receives what you expect to receive.
Some useful pkt-gen options are -R (to rate limit the transmitter), and `-f
txseq` (on the sender) and -f rxseq (on the receiver) to let the
sender/receiver use sequence numbers and check if you lose packets.

Jan 6 2021, 7:16 PM
rajesh1.kumar_amd.com added a comment to D27877: Support for NS_MOREFRAG in Netmap bridge utility.

@vmaffione, Thanks for the simplified patch. Network bridging with and without zerocopy is working properly (it needs D27799 netmap_txsync changes)

Jan 6 2021, 7:01 PM

Jan 5 2021

rajesh1.kumar_amd.com added a reviewer for D27797: AMD 10GbE driver changes for Netmap support: vmaffione.
Jan 5 2021, 6:55 AM
rajesh1.kumar_amd.com added a comment to D27799: Iflib changes to handle multiple netmap fragments.

Thanks for your time and comments.

Jan 5 2021, 6:55 AM

Jan 1 2021

rajesh1.kumar_amd.com added reviewers for D27877: Support for NS_MOREFRAG in Netmap bridge utility: mmacy, manu, vmaffione.
Jan 1 2021, 12:21 PM
rajesh1.kumar_amd.com updated the diff for D27799: Iflib changes to handle multiple netmap fragments.

V2 patch with previous review comments addressed.

Jan 1 2021, 12:19 PM
rajesh1.kumar_amd.com requested review of D27877: Support for NS_MOREFRAG in Netmap bridge utility.
Jan 1 2021, 12:16 PM
rajesh1.kumar_amd.com added a comment to D27800: Man page for AMD 10GbE driver.

Thanks for the comments.

Jan 1 2021, 11:59 AM
rajesh1.kumar_amd.com updated the diff for D27800: Man page for AMD 10GbE driver.

V2 patch with review comments addressed

Jan 1 2021, 11:49 AM

Dec 28 2020

rajesh1.kumar_amd.com updated the summary of D27797: AMD 10GbE driver changes for Netmap support.
Dec 28 2020, 12:43 PM
rajesh1.kumar_amd.com added reviewers for D27799: Iflib changes to handle multiple netmap fragments: mmacy, manu.
Dec 28 2020, 12:40 PM
rajesh1.kumar_amd.com added reviewers for D27800: Man page for AMD 10GbE driver: manu, andrew, stephan.dewt_yahoo.co.uk.
Dec 28 2020, 12:39 PM
rajesh1.kumar_amd.com requested review of D27800: Man page for AMD 10GbE driver.
Dec 28 2020, 12:23 PM
rajesh1.kumar_amd.com requested review of D27799: Iflib changes to handle multiple netmap fragments.
Dec 28 2020, 12:22 PM
rajesh1.kumar_amd.com requested review of D27797: AMD 10GbE driver changes for Netmap support.
Dec 28 2020, 10:30 AM

Oct 18 2020

rajesh1.kumar_amd.com added a comment to D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.

Thanks @adrian for taking on this. From a compilation perspective, Looks good. I don't have any more specific comments.

Oct 18 2020, 6:54 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

@kevans, Is it possible to share your hardware details? do you have a test hardware with RJ45 ports? Any specific reason why it's been compiled with GCC?

Oct 18 2020, 6:14 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

GCC points out that this statement does nothing, XGBE_ADV expands to ((_phy)->advertising & ADVERTISED_##_mode)

Oct 18 2020, 5:12 PM

Oct 12 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Could I ask for a manpage too ?

Oct 12 2020, 9:01 AM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Thanks @manu for committing this driver.

Oct 12 2020, 8:55 AM

Oct 9 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Talking to my peers here, looks like there is a similar issue being reported internally. That seems related to Auto-negotiation and PCS hardware. But, I am yet to get the full details of the same. I will update once I get the details.

Oct 9 2020, 7:40 AM

Oct 8 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

I have been trying the hotplug/hotunplug experiment in my setup which is a back-to-back connection between the AMD SFP ports and an external link partner. As I have mentioned earlier, Intermittently I could see the delay in link coming up, and when that happens, I observe the similar behavior of PCS register having value of 0xC2 (even though sfp gpio signals are sensing the link immediately). We expect a value of 0x46 (bit[2] to be set basically). One possible reason could be the CDR workaround. But that option is ruled out. Adding to it, I see the delay only when the SFP module is touched, but not when just the link is hotplugged/unplugged. But I haven't experienced a scenario where the link doesn't come up at all.

Oct 8 2020, 9:46 AM

Oct 7 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Regarding the link issue you are facing, can you try setting "an_cdr_workaround = 0" in if_axgbe_pci.c in appropriate version and give a try?

Oct 7 2020, 6:08 AM

Oct 3 2020

rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.

Fixed the build issues with arm64 and corrected the config files as needed

Oct 3 2020, 2:37 PM

Oct 2 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Finally buildworld completes after around 3 hours. Looks like the issue is because of the missing files mentioned in files.<arch>

Oct 2 2020, 4:23 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

I am trying to build for arm64. It's taking a lot of time to buildworld (even with 16 threads). I will see how it goes.

Oct 2 2020, 12:55 PM

Oct 1 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Hi @manu. Fixed the GENERIC file. Please let me know if anything else needs to be taken care.

Oct 1 2020, 9:56 AM
rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.

Fixed the sys/amd64/conf/GENERIC mis-merge

Oct 1 2020, 9:55 AM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Fine @manu. I will update it.

Oct 1 2020, 8:40 AM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Thanks for pointing the mis-merge @manu. Sorry about that.

Oct 1 2020, 8:31 AM
rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.

Changes:

  1. Increased timeout from 1 to 20 for SFP EEPROM read
  2. Changes to add supports for appropriate media types
  3. Changes to list appropriate media type in ifconfig output
  4. Logging changes.
Oct 1 2020, 6:14 AM

Sep 30 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

The issue is seen both during hotplug/hotunplug. As I said, I tried to create a reproducible scenario. During testing this morning, I tried:

Sep 30 2020, 5:57 AM

Sep 28 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

The increased timeout indeed eliminates the issue of reading the EEPROM. I don't think this has anything to do with the link issue, as there is (as far as I know) a service timer that executes every second to see if any signals have changed, it then proceeds to read the EEPROM again, regardless of whether the module has changed. We should not see a Link UP after 30 seconds or more (or never) if the service timer executes every second.

Sep 28 2020, 10:15 AM

Sep 25 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Thanks @stephan.dewt_yahoo.co.uk for the detailed info and sharing the logs.

Sep 25 2020, 11:18 AM

Sep 24 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Regarding the following statement, Does it mean the Link doesn't come up at all? or It takes some delay to come up?

Sep 24 2020, 8:04 PM

Sep 16 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Fine. Good to hear you could progress @manu. I will make that logging change and update the patch.

Sep 16 2020, 5:09 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

It's a logging mistake @manu. I will correct it accordingly. Each nibble in that value denotes a port status. When you say you are touching only ax0, I see the correct nibble reflecting the change (bits[15:12]). From the values you showed here, looks like your SFP module is detected, but Link is still not. Is the link connected?

Sep 16 2020, 4:57 PM

Sep 12 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

@manu, all the discussed changes (avoid repetitive logs, fix the debug sysctl, and your changes in P422) are done and updated the patch here.

Sep 12 2020, 4:12 PM
rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.
  1. Fixed the debug sysctl to be device instance specific
  2. Minor Logging changes
Sep 12 2020, 4:00 PM

Sep 10 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Ok, weird that my modules doesn't work then no ?

Sep 10 2020, 5:55 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

I only have finisar ftlx8574d3bcl for now, do you have a known model that is supposed to work ?
Also can you make the printf not in a loop ?

Sep 10 2020, 4:58 PM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Hi @manu, Thanks for trying the patch and making other necessary changes. Sorry, I missed to make that change MPASS (nrxqs == 2) when I submitted the v4 patch.

Sep 10 2020, 4:31 PM

Sep 7 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Does anyone have any more comments on this patch?

Sep 7 2020, 11:23 AM

Aug 28 2020

rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.

Changes :

  1. Removed unwanted header files from unwanted places
  2. Changed Rx path to use 2 Freelist instead of 1. Rx descriptors holds header and data buffers. Earlier use entries in one freelist were used to populate one descriptor. Now with 2 freelists, one entry from each freelist is used to populated on descriptor. This way the indexes will be in sync between driver and iflib
Aug 28 2020, 7:28 AM

Aug 25 2020

rajesh1.kumar_amd.com added a comment to D25409: AMD Passthrough DMA Engine Driver.

Hi @cem, Do you have any more comments on this patch?

Aug 25 2020, 4:35 AM
rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Any more comments on this patch?

Aug 25 2020, 4:33 AM

Aug 1 2020

rajesh1.kumar_amd.com added inline comments to D25793: 10Gigabit Ethernet driver for AMD SoC.
Aug 1 2020, 8:32 AM
rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.
  1. Removed "All rights reserved" and corrected years in the copyright
  2. Added a minor change in i2c and phy-v2 files for link status update for multi-port
Aug 1 2020, 8:31 AM

Jul 31 2020

rajesh1.kumar_amd.com added inline comments to D25793: 10Gigabit Ethernet driver for AMD SoC.
Jul 31 2020, 7:06 AM
rajesh1.kumar_amd.com updated the diff for D25793: 10Gigabit Ethernet driver for AMD SoC.

Change details :

  1. Added SPDX-License Identifier for possible files with BSD-2-Clause-FreeBSD
  2. Moved copyright tags out of the License text as per the comment
  3. Changed to C style comments.
  4. Removed commented code and added TODO tags.
Jul 31 2020, 6:44 AM

Jul 27 2020

rajesh1.kumar_amd.com added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Can we add an appropriate SPDX tag to the source files as well - e.g. /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ or similar?

Jul 27 2020, 7:34 AM
rajesh1.kumar_amd.com added a comment to D25409: AMD Passthrough DMA Engine Driver.

Fine @cem. No issues.

Jul 27 2020, 3:59 AM

Jul 24 2020

rajesh1.kumar_amd.com added reviewers for D25793: 10Gigabit Ethernet driver for AMD SoC: manu, manu_bidouilliste.com.
Jul 24 2020, 9:14 AM
rajesh1.kumar_amd.com requested review of D25793: 10Gigabit Ethernet driver for AMD SoC.
Jul 24 2020, 6:10 AM