Page MenuHomeFreeBSD
Differential D27173

Add regression test for D27164
ClosedPublic
Actions

Authored by jtl on Nov 11 2020, 3:43 AM.
Tags
None
Referenced Files
F157751399: D27173.id79549.diff
Sun, May 24, 8:29 PM
F157751396: D27173.id79549.diff
Sun, May 24, 8:29 PM
F157750922: D27173.id79549.diff
Sun, May 24, 8:22 PM
Unknown Object (File)
Mon, May 18, 10:21 AM
Unknown Object (File)
Mon, May 18, 10:17 AM
Unknown Object (File)
Sun, May 10, 6:42 PM
Unknown Object (File)
Sun, May 3, 1:15 AM
Unknown Object (File)
Apr 24 2026, 8:59 PM
View All Files
Subscribers
asomers
imp
melifaro

Details

Reviewers
olivier
tuexen
markj
bz
Group Reviewers
transport
Commits
rS367685: Add a regression test for the port-selection behavior fixed in r367680.
Summary

D27164 describes a problem with (and fix for) implicit local port selection as part of the connect() call. This regression test fails for IPv6 without the fix and passes with the fix.

Test Plan

Run the regression test with and without the fix. Verify the test fails without the fix and passes with the fix.

Without the fix:

sys/netinet/tcp_connect_port_test:basic_ipv4  ->  passed  [2.093s]
sys/netinet/tcp_connect_port_test:basic_ipv6  ->  failed: /home/ec2-user/ocafirmware/FreeBSD/tests/sys/netinet/tcp_connect_port_test.c:245: client socket 55535 using the same port as server  [1.972s]

With the fix:

sys/netinet/tcp_connect_port_test:basic_ipv4  ->  passed  [2.109s]
sys/netinet/tcp_connect_port_test:basic_ipv6  ->  passed  [2.486s]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34738
Build 31794: arc lint + arc unit

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
3 lines
334 lines

Diff 79418

View Options

tests/sys/netinet/Makefile

Loading...
View Options

tests/sys/netinet/tcp_connect_port_test.c

Loading...